Todd Lipcon has posted comments on this change.

Change subject: Stop using shared_ptr<DeltaIterator>
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3098/1/src/kudu/tablet/delta_iterator_merger.cc
File src/kudu/tablet/delta_iterator_merger.cc:

Line 37:     vector<unique_ptr<DeltaIterator> > iters)
> Nit: if you want, fix >> and & placement in the lines you're touching.
eh, will skip for now and maybe do a global find/replace at some point


-- 
To view, visit http://gerrit.cloudera.org:8080/3098
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9293fe20403a21f483ec9bfe0dd39b8e614fbd68
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to