Todd Lipcon has submitted this change and it was merged. Change subject: Stop using shared_ptr<DeltaIterator> ......................................................................
Stop using shared_ptr<DeltaIterator> These objects were never shared, but shared_ptr was used long ago because we were unable to put scoped pointers inside vectors. Now with C++11 we can use unique_ptr and avoid these unnecessary shared_ptrs. This might have a small performance improvement due to reduced atomics, but more importantly it makes it obvious that these are single-owner objects. Change-Id: I9293fe20403a21f483ec9bfe0dd39b8e614fbd68 Reviewed-on: http://gerrit.cloudera.org:8080/3098 Tested-by: Kudu Jenkins Reviewed-by: Adar Dembo <[email protected]> --- M src/kudu/tablet/compaction.cc M src/kudu/tablet/delta_applier.cc M src/kudu/tablet/delta_applier.h M src/kudu/tablet/delta_compaction-test.cc M src/kudu/tablet/delta_compaction.cc M src/kudu/tablet/delta_compaction.h M src/kudu/tablet/delta_iterator_merger.cc M src/kudu/tablet/delta_iterator_merger.h M src/kudu/tablet/delta_tracker.cc M src/kudu/tablet/delta_tracker.h M src/kudu/tablet/diskrowset-test.cc M src/kudu/tablet/diskrowset.cc 12 files changed, 56 insertions(+), 49 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9293fe20403a21f483ec9bfe0dd39b8e614fbd68 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]>
