PragmaTwice commented on PR #564: URL: https://github.com/apache/incubator-kvrocks/pull/564#issuecomment-1123444089
> @git-hulk @ShooterIT as stated in [#564 (comment)](https://github.com/apache/incubator-kvrocks/pull/564#issuecomment-1121972637), we may proceed this patch to introduce a `FetchContent` based cmake build system. And remove Makefile build system in a separated PR. > > cc @PragmaTwice do I get it right? Yeah, I I also think it would be good to remove makefiles after this PR. > BTW, i ever wanted to remove Makefile, only keep cmake, since we need to install some libs firstly if we use make. @git-hulk told me we need a high version cmake which may be not convenient for users. I don't know 3.16 is high? If not, maybe in the future, we can only support cmake. You can easily get cmake binaries from https://github.com/Kitware/CMake/releases (I do not try it in an old distro environment like centos or debian stable, but I do know some glibc linking issue will appear while the glibc version in build environment is higher than it in user's environment). I think the most compatible way to use cmake is to build it by your own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
