PragmaTwice commented on code in PR #564:
URL: https://github.com/apache/incubator-kvrocks/pull/564#discussion_r870162990
##########
cmake/gtest.cmake:
##########
@@ -15,38 +15,18 @@
# specific language governing permissions and limitations
# under the License.
-if (NOT __GTEST_INCLUDED) # guard against multiple includes
- set(__GTEST_INCLUDED TRUE)
+include_guard()
- # gtest will use pthreads if it's available in the system, so we must link
with it
- find_package(Threads)
+include(FetchContent)
- # build directory
- set(gtest_PREFIX ${CMAKE_BUILD_DIRECTORY}/external/gtest-prefix)
- # install directory
- set(gtest_INSTALL ${CMAKE_BUILD_DIRECTORY}/external/gtest-install)
+FetchContent_Declare(gtest
+ GIT_REPOSITORY https://github.com/google/googletest/
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
