PragmaTwice commented on code in PR #618:
URL: https://github.com/apache/incubator-kvrocks/pull/618#discussion_r888844042
##########
CMakeLists.txt:
##########
@@ -45,6 +45,8 @@ if(NOT DISABLE_JEMALLOC)
list(APPEND EXTERNAL_LIBS PRIVATE jemalloc)
endif()
+set(BUILD_SHARED_LIBS OFF CACHE BOOL "do not build shared libs by default")
Review Comment:
I think we just want to build static libraries of dependences and link them
statically, so I added it to CMakeLists to avoid some dependencies set this
cache variable to true in their cmake to pollute this configuration. (cache
variables can only be assigned once, and the next assignment needs to specify
`FORCE`, otherwise it is invalid)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
