PragmaTwice commented on code in PR #618:
URL: https://github.com/apache/incubator-kvrocks/pull/618#discussion_r888847179
##########
CMakeLists.txt:
##########
@@ -45,6 +45,8 @@ if(NOT DISABLE_JEMALLOC)
list(APPEND EXTERNAL_LIBS PRIVATE jemalloc)
endif()
+set(BUILD_SHARED_LIBS OFF CACHE BOOL "do not build shared libs by default")
Review Comment:
Static libraries allow users to not worry about library versioning issues
and linking issues, and are more portable (just like go / rust, statically link
almost everything), which I think is probably secondary to the increase in size
of these binaries.
And `BUILD_SHARED_LIBS` only controls the default behavior, if we want to
build dynamic libraries then we can still specify it manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
