Hi Hulk, I thought we can put it next to `licenses/LICENSE.redis` before, but it seems some Apache projects did append these dependency licenses directly to LICENSE, so it is good for me now.
Twice On Thu, Jul 21, 2022 at 10:48 PM hulk <[email protected]> wrote: > I tried to add the license notice for dependencies in the below PR: > > https://github.com/apache/incubator-kvrocks/pull/744/files > > Does this look good to you? > > On Thu, 21 Jul 2022 at 18:35, hulk <[email protected]> wrote: > > > Hi, all > > > > In the vote thread of Kvrocks 2.1.0: > > https://lists.apache.org/thread/v5odwj3or00h54qwp0n0f05c18fo4mll. > > > > JB and Xiaoqiao reminded us that we should also declare licenses for > > Kvrocks dependencies. > > But I'm not sure how can we declare since we only fetch them when > building > > the binary, > > and didn't bundle them directly in source codes. > > > > -- > > Best Regards, > > - *Hulk Lin* > > > > > -- > Best Regards, > - *Hulk Lin* >
