Hi, It's a good approach.
Don't forget to summarize the different licenses and projects used in the NOTICE file as well. Thanks ! Regards JB On Fri, Jul 22, 2022 at 8:33 AM hulk <[email protected]> wrote: > > Thanks, Twice > > Yes, I saw most projects put those licenses after the License file, so I > follow them. > > On Thu, 21 Jul 2022 at 23:46, Twice <[email protected]> wrote: > > > Hi Hulk, > > > > I thought we can put it next to `licenses/LICENSE.redis` before, > > but it seems some Apache projects did append these dependency licenses > > directly to LICENSE, > > so it is good for me now. > > > > Twice > > > > On Thu, Jul 21, 2022 at 10:48 PM hulk <[email protected]> wrote: > > > > > I tried to add the license notice for dependencies in the below PR: > > > > > > https://github.com/apache/incubator-kvrocks/pull/744/files > > > > > > Does this look good to you? > > > > > > On Thu, 21 Jul 2022 at 18:35, hulk <[email protected]> wrote: > > > > > > > Hi, all > > > > > > > > In the vote thread of Kvrocks 2.1.0: > > > > https://lists.apache.org/thread/v5odwj3or00h54qwp0n0f05c18fo4mll. > > > > > > > > JB and Xiaoqiao reminded us that we should also declare licenses for > > > > Kvrocks dependencies. > > > > But I'm not sure how can we declare since we only fetch them when > > > building > > > > the binary, > > > > and didn't bundle them directly in source codes. > > > > > > > > -- > > > > Best Regards, > > > > - *Hulk Lin* > > > > > > > > > > > > > -- > > > Best Regards, > > > - *Hulk Lin* > > > > > > > > -- > Best Regards, > - *Hulk Lin*
