+1 on Git Pull Requests. We should use same process for regular contributors as the one we advocate for new contributors. Pull request should be a standard practice for the very purpose. I suggest getting rid of https://github.com/KylinOLAP/Kylin all together.
- Ankur On Wed, Mar 18, 2015 at 1:35 PM, Julian Hyde <[email protected]> wrote: > How do people feel about pull requests and the github mode of development? > I agree with Ted that regular contributors should become committers, but > for others, or even for committers who are not ready to commit to trunk, > github forks and pull requests are a good way of working in public and > getting feedback early. Anyone who wants to contribute to kylin could > easily create a github account. > > Julian > > > On Mar 18, 2015, at 10:55 AM, Ted Dunning <[email protected]> wrote: > > > On Tue, Mar 17, 2015 at 10:09 PM, Luke Han <[email protected]> wrote: > > > >> The other one is our staging code repo to simplify development since > many > >> of our team members do not have push privileges to Apache one yet (This > >> approach will be changed anytime without notification). > >> > > > > This is not a good practice. Effectively, what is happening is that > > development is happening in private with occasional burps to the public > > repo. > > > > If you have lots of people that you trust to be committers, you should > > start a vote to make them committers. Having more committers is not a > > problem... it is a good thing. > >
