pan3793 commented on code in PR #1:
URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1090515837
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
+
+ARG kyuubi_uid=10009
+
+USER root
+
+ENV KYUUBI_HOME /opt/kyuubi
+ENV KYUUBI_LOG_DIR ${KYUUBI_HOME}/logs
+ENV KYUUBI_PID_DIR ${KYUUBI_HOME}/pid
+ENV KYUUBI_WORK_DIR_ROOT ${KYUUBI_HOME}/work
+
+RUN set -ex; \
+ sed -i 's/http:\/\/deb.\(.*\)/https:\/\/deb.\1/g' /etc/apt/sources.list; \
+ apt-get update && \
Review Comment:
could you please use `&& \` in all places?
##########
release/DOI-Dockerfile.template:
##########
@@ -0,0 +1,44 @@
+FROM eclipse-temurin:8-jdk-focal
+
+ARG kyuubi_uid=10009
+
+USER root
+
+ENV
KYUUBI_SOURCE_TGZ_URL=https://archive.apache.org/dist/incubator/kyuubi/kyuubi-1.6.0-incubating/apache-kyuubi-1.6.0-incubating-source.tgz
Review Comment:
1.6.1
##########
release/DOI-Dockerfile.template:
##########
@@ -0,0 +1,44 @@
+FROM eclipse-temurin:8-jdk-focal
+
+ARG kyuubi_uid=10009
+
+USER root
+
+ENV
KYUUBI_SOURCE_TGZ_URL=https://archive.apache.org/dist/incubator/kyuubi/kyuubi-1.6.0-incubating/apache-kyuubi-1.6.0-incubating-source.tgz
+
+ARG SPARK_PROVIDED="--spark-provided"
+ARG FLINK_PROVIDED="--flink-provided"
+ARG HIVE_PROVIDED="--hive-provided"
+
+ENV KYUUBI_HOME=/opt/kyuubi
+ENV KYUUBI_WORK_DIR_ROOT=${KYUUBI_HOME}/work
+
+RUN set -ex; \
+ sed -i 's/http:\/\/deb.\(.*\)/https:\/\/deb.\1/g' /etc/apt/sources.list; \
+ apt-get update && \
+ apt install -y wget bash tini libc6 libpam-modules krb5-user libnss3
procps; \
+ mkdir -p ${KYUUBI_HOME}
+
+# build binary from source
+RUN set -ex; \
+ export KYUUBI_SOURCE_HOME="$(mktemp -d)"; \
+ cd ${KYUUBI_SOURCE_HOME}; \
+ wget -O kyuubi.tgz ${KYUUBI_SOURCE_TGZ_URL}; \
Review Comment:
how about reserving the original name?
##########
.gitignore:
##########
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+*#*#
+*.#*
+*.iml
+*.ipr
+*.iws
+*.pyc
+*.pyo
+*.swp
+*~
+.DS_Store
+.cache
+.classpath
+.ensime
+.ensime_cache/
+.ensime_lucene
+.generated-mima*
+.vscode/
+.idea/
+# The star is required for further !/.idea/ to work, see
https://git-scm.com/docs/gitignore
+/.idea/*
+# Icon for JetBrains Toolbox
+!/.idea/icon.png
+!/.idea/vcs.xml
Review Comment:
let's remove them, it's useless
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
Review Comment:
why not jdk? jre lacks some java command, I'm not sure if `jps` is supplied
##########
1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile:
##########
@@ -0,0 +1,31 @@
+FROM eclipse-temurin:8-jre
+
+ARG kyuubi_uid=10009
+
+USER root
+
+ENV KYUUBI_HOME /opt/kyuubi
+ENV KYUUBI_LOG_DIR ${KYUUBI_HOME}/logs
+ENV KYUUBI_PID_DIR ${KYUUBI_HOME}/pid
+ENV KYUUBI_WORK_DIR_ROOT ${KYUUBI_HOME}/work
+
+RUN set -ex; \
+ sed -i 's/http:\/\/deb.\(.*\)/https:\/\/deb.\1/g' /etc/apt/sources.list; \
+ apt-get update && \
+ apt install -y wget bash tini libc6 libpam-modules krb5-user libnss3
procps; \
+ mkdir -p ${KYUUBI_HOME} ${KYUUBI_LOG_DIR} ${KYUUBI_PID_DIR}
${KYUUBI_WORK_DIR_ROOT}
Review Comment:
please clean apt cache to reduce the image size
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
