bowenliang123 commented on code in PR #1: URL: https://github.com/apache/kyuubi-docker/pull/1#discussion_r1091335803
########## 1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile: ########## @@ -0,0 +1,31 @@ +FROM eclipse-temurin:8-jre Review Comment: We could make it configurable as the way in Spark's official dockerfile. 1. jre by default 2. set from arg `java_image_tag` https://github.com/apache/spark/blob/0db63df2b2829f1358fb711cd657a22b7838ece2/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile#L17 ``` ARG java_image_tag=17-jre FROM eclipse-temurin:${java_image_tag} ``` ########## 1.6.1-incubating/scala2.12-java8-ubuntu/Dockerfile: ########## @@ -0,0 +1,31 @@ +FROM eclipse-temurin:8-jre Review Comment: We could make it configurable as the way in Spark's official dockerfile. 1. jre by default 2. set from arg `java_image_tag` https://github.com/apache/spark/blob/main/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/Dockerfile#L17 ``` ARG java_image_tag=17-jre FROM eclipse-temurin:${java_image_tag} ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
