----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37346/#review97258 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 487) <https://reviews.apache.org/r/37346/#comment153095> One in-memory result that is not fetched should not block other queries to be purged. Can you check if that can happen? - Amareshwari Sriramadasu On Aug. 27, 2015, 12:47 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37346/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 12:47 p.m.) > > > Review request for lens. > > > Bugs: LENS-693 > https://issues.apache.org/jira/browse/LENS-693 > > > Repository: lens > > > Description > ------- > > Query Result Mail is not working when finished queries is set to zero as the > queries are immediately going to the DB. > > Did some refactoring in order to use inheritence instead of instanceof. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/LensConf.java > 3b1ad87ffe16b572437b92d90c793ea1881c2e0d > lens-api/src/main/java/org/apache/lens/api/query/InMemoryQueryResult.java > 6a9f4558afc3a8430b43dcc65d73c813575a334d > lens-api/src/main/java/org/apache/lens/api/query/PersistentQueryResult.java > a2e10c6560aaa551a15408b2937c3d495b51af5f > lens-api/src/main/java/org/apache/lens/api/query/QueryResult.java > 3ecf0c229494dd82a531bc5a310e3b056a86d451 > lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java > 9614caa3ef3d111b5d1728f6df854623b9effbfb > lens-cli/src/main/java/org/apache/lens/cli/commands/LensQueryCommands.java > 7a5b177538e4a8c946422ff905c6c048d828b6ab > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 31c343a7b72c13ff9eb9b01038574297629e381b > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HivePersistentResultSet.java > 00e1e53444ca76fa5096efc69fc4bdfdd16d116a > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 78b3320977f9b46b2719ba80190fa77e87ecc729 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/InMemoryResultSet.java > 3b761268645acf150d149e51f69521bf164c61ee > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSet.java > 929a3026da9d9789b64ab1f04fdd063db3443432 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/PersistentResultSet.java > bbde1705fec7fb946708b17d57eb5ad74fcb7cef > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java > 6cecf7eb52d0788cd0b4fb0b624229b1eefe72b7 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > beaa72fbe06c33e116a8ff2f45ee62f2fcd17af1 > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > b28669e9070578e5121eb4b1c59e8e3ac7cb83de > > lens-server/src/main/java/org/apache/lens/server/query/LensPersistentResult.java > b65a5f4ac661f060b51d5ee1c899dfd93aa8be90 > > lens-server/src/main/java/org/apache/lens/server/query/QueryEndNotifier.java > 45ba7ac0300cc7b1d5d2ab723c4adf8d60801e11 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c29a1ac4be7c44c13e3d1e964b18c240adb61d5f > lens-server/src/main/java/org/apache/lens/server/query/ResultFormatter.java > af42eb06e2c030a7040b970e982cab782b2bb251 > > lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java > 0945598eed81515702402e9933b2592186209508 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java > 82ce205c8d54c6665262ee3baf8c521203743eb5 > > Diff: https://reviews.apache.org/r/37346/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.439s] > [INFO] Lens .............................................. SUCCESS [3.146s] > [INFO] Lens API .......................................... SUCCESS [21.540s] > [INFO] Lens API for server and extensions ................ SUCCESS [19.002s] > [INFO] Lens Cube ......................................... SUCCESS [5:06.032s] > [INFO] Lens DB storage ................................... SUCCESS [19.632s] > [INFO] Lens Query Library ................................ SUCCESS [17.437s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:49.180s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [35.413s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [18.255s] > [INFO] Lens Server ....................................... SUCCESS [6:10.729s] > [INFO] Lens client ....................................... SUCCESS [38.716s] > [INFO] Lens CLI .......................................... SUCCESS [2:37.862s] > [INFO] Lens Examples ..................................... SUCCESS [10.414s] > [INFO] Lens Distribution ................................. SUCCESS [8.630s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:19.199s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.027s] > [INFO] Lens Regression ................................... SUCCESS [10.184s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 21:30.753s > [INFO] Finished at: Thu Aug 27 12:32:47 UTC 2015 > [INFO] Final Memory: 192M/1814M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
