----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37934/ -----------------------------------------------------------
(Updated Sept. 2, 2015, 11:39 a.m.) Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat Khandelwal, and sharad agarwal. Changes ------- - Extending lens exception and mapping the error codes - Removed syntax error code and added more meaningful codes - Using lensserver db for saving the queries - Updated utility methods to produce a pooling data source (All test cases working fine) Repository: lens Description ------- Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742 (Note : Sharing and CLI are not a part of this patch) Diffs (updated) ----- lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java 754e6e1 lens-api/src/main/resources/lens-errors.conf 3fb191e lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/save/QueryValidatorResponse.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java PRE-CREATION lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterParserTest.java PRE-CREATION lens-server-api/src/test/java/org/apache/lens/server/api/query/save/ParameterResolutionTest.java PRE-CREATION lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java PRE-CREATION lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java PRE-CREATION lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java PRE-CREATION lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java PRE-CREATION lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java PRE-CREATION lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java PRE-CREATION lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java 5d77eb7 lens-server/src/main/resources/lensserver-default.xml 5d33eda lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java PRE-CREATION lens-server/src/test/resources/lens-site.xml 4cf94d5 Diff: https://reviews.apache.org/r/37934/diff/ Testing ------- Have added unit test cases for parsing, resolution of parameter and service testing. Thanks, Amruth Sampath
