> On Sept. 7, 2015, 9:44 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java, > > line 31 > > <https://reviews.apache.org/r/37934/diff/3/?file=1064152#file1064152line31> > > > > Same as above - If this requires interaction with user/client, it > > should be lens-api package. > > Amruth Sampath wrote: > The ParameterDataType and ParameterCollectionType throws some exceptions > which are extending from LensException (so that error code mapping is done > automatically). > > Moving this to lens-api would mean LensException is not vissible anymore. > Should I rather create wrapper around these exceptions @ lens-server-api?
Exceptions cannot be thrown from REST api request/response elements. If you want to pass payload to clients, have a look at FieldsCannotBeQueriedTogetherException to see how payload can be passed. If no sending payload is required, leaving the exceptions in server-api and server side classes throwing exception is good enough - clients would get appropriate error with error code mapped correctly. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37934/#review97907 ----------------------------------------------------------- On Sept. 4, 2015, 5:25 p.m., Amruth Sampath wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37934/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2015, 5:25 p.m.) > > > Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat > Khandelwal, and sharad agarwal. > > > Repository: lens > > > Description > ------- > > Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742 > (Note : Sharing and CLI are not a part of this patch) > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java > 754e6e1 > lens-api/src/main/resources/lens-errors.conf 3fb191e > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > 0dfd7da > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 586629f > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/Parameter.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterCollectionType.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterDataType.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParser.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterParserResponse.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/ParameterResolver.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQuery.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/ListResponse.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/ResourceModifiedResponse.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryApp.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryDao.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryResource.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/savedquery/SavedQueryServiceImpl.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > 5d77eb7 > lens-server/src/main/resources/lensserver-default.xml 5d33eda > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > 2189eb8 > > lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java > PRE-CREATION > lens-server/src/test/resources/lens-site.xml 4cf94d5 > > Diff: https://reviews.apache.org/r/37934/diff/ > > > Testing > ------- > > Have added unit test cases for parsing, resolution of parameter and service > testing. > > > Thanks, > > Amruth Sampath > >