-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39127/#review101906
-----------------------------------------------------------



lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 (line 429)
<https://reviews.apache.org/r/39127/#comment159406>

    I feel instead of adding this public method, setting priority after 
deciding would have been better.


Can we add a unit test ?

- Amareshwari Sriramadasu


On Oct. 8, 2015, 1:18 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39127/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 1:18 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-807
>     https://issues.apache.org/jira/browse/LENS-807
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> small bug
> 
> 
> Diffs
> -----
> 
>   lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 
> 4561ccf3424958b251b8eb31c649341bae8104c9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java
>  0c980a20953efc6c2d7cc17c97b1552c64a8eb5f 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
>  ac942077d78515404b83f4a02f841b73dd39e3df 
> 
> Diff: https://reviews.apache.org/r/39127/diff/
> 
> 
> Testing
> -------
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.175s]
> [INFO] Lens .............................................. SUCCESS [2.947s]
> [INFO] Lens API .......................................... SUCCESS [23.439s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.441s]
> [INFO] Lens Cube ......................................... SUCCESS [6:11.745s]
> [INFO] Lens DB storage ................................... SUCCESS [22.402s]
> [INFO] Lens Query Library ................................ SUCCESS [18.196s]
> [INFO] Lens Hive Driver .................................. SUCCESS [3:06.859s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [35.658s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.347s]
> [INFO] Lens Server ....................................... SUCCESS [8:17.698s]
> [INFO] Lens client ....................................... SUCCESS [34.376s]
> [INFO] Lens CLI .......................................... SUCCESS [2:36.033s]
> [INFO] Lens Examples ..................................... SUCCESS [9.886s]
> [INFO] Lens Distribution ................................. SUCCESS [8.592s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:19.730s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.106s]
> [INFO] Lens Regression ................................... SUCCESS [11.178s]
> [INFO] Lens UI ........................................... SUCCESS [22.051s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 25:23.999s
> [INFO] Finished at: Thu Oct 08 12:59:09 UTC 2015
> [INFO] Final Memory: 194M/2044M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Reply via email to