> On Oct. 13, 2015, 1:37 p.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, > > line 207 > > <https://reviews.apache.org/r/39127/diff/2/?file=1095321#file1095321line207> > > > > Can we avoid opening up the constructor?
Have made MockQueryContext extend QueryContext instead of AbstractQueryContext. One constructor had to be opened up. Can make it protected if you'd like. package local is still not `public` though. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39127/#review102408 ----------------------------------------------------------- On Oct. 12, 2015, 1:52 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39127/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2015, 1:52 p.m.) > > > Review request for lens. > > > Bugs: LENS-807 > https://issues.apache.org/jira/browse/LENS-807 > > > Repository: lens > > > Description > ------- > > small bug > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 4561ccf3424958b251b8eb31c649341bae8104c9 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 2cb3736d45d51fd2172e99ca086843fc6ce50079 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > ac942077d78515404b83f4a02f841b73dd39e3df > > lens-server-api/src/test/java/org/apache/lens/server/api/query/MockQueryContext.java > 3d38eab9a37410468694a8954e45f497f23d1072 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java > 847d12a7e25e2db68d5f7fba910aa1027882ec27 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/MockQueryCostCalculator.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/query/priority/MockQueryPriorityDecider.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/util/TestLensUtil.java > caee12f4a39388c39eac656949e9c16bf4dfdea7 > > lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java > e266ef223e463791e26b6a7a59818e7495bc0235 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryEndEmailNotifier.java > 3bb90efc9c2a859d1c339e6b21a4048a2b2222ef > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 6218882facf93216211c50d264e2e6e9cf64a122 > > Diff: https://reviews.apache.org/r/39127/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.175s] > [INFO] Lens .............................................. SUCCESS [2.947s] > [INFO] Lens API .......................................... SUCCESS [23.439s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.441s] > [INFO] Lens Cube ......................................... SUCCESS [6:11.745s] > [INFO] Lens DB storage ................................... SUCCESS [22.402s] > [INFO] Lens Query Library ................................ SUCCESS [18.196s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:06.859s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [35.658s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.347s] > [INFO] Lens Server ....................................... SUCCESS [8:17.698s] > [INFO] Lens client ....................................... SUCCESS [34.376s] > [INFO] Lens CLI .......................................... SUCCESS [2:36.033s] > [INFO] Lens Examples ..................................... SUCCESS [9.886s] > [INFO] Lens Distribution ................................. SUCCESS [8.592s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:19.730s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.106s] > [INFO] Lens Regression ................................... SUCCESS [11.178s] > [INFO] Lens UI ........................................... SUCCESS [22.051s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 25:23.999s > [INFO] Finished at: Thu Oct 08 12:59:09 UTC 2015 > [INFO] Final Memory: 194M/2044M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
