----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39191/#review102206 -----------------------------------------------------------
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (lines 108 - 114) <https://reviews.apache.org/r/39191/#comment159780> Shall we separate these tests also into separate test methods? lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (lines 123 - 126) <https://reviews.apache.org/r/39191/#comment159779> Can you if we can use same client in all tests instead of creating one fore each ? We can create one simple client, one with metrics enabled at class level - in the constructor ? If not, can we move this to a method ? - Amareshwari Sriramadasu On Oct. 9, 2015, 10:14 p.m., Gabor Liptak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39191/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 10:14 p.m.) > > > Review request for lens. > > > Bugs: LENS-615 > https://issues.apache.org/jira/browse/LENS-615 > > > Repository: lens > > > Description > ------- > > LENS-615 Refactoring of testQueryCommands test case > > > Diffs > ----- > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 > > Diff: https://reviews.apache.org/r/39191/diff/ > > > Testing > ------- > > > Thanks, > > Gabor Liptak > >
