----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39191/#review102406 -----------------------------------------------------------
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (line 77) <https://reviews.apache.org/r/39191/#comment160036> Both `setupQueryCommands` and `setupQueryCommandsWithMetrics` are same except for one extra line. They can be merged into one method with boolean argument. lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (lines 100 - 110) <https://reviews.apache.org/r/39191/#comment160038> Two wrapper methods calling one method with different arguments. Maybe you can look at data providers in testng. It'll greatly reduce the redundancies. lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (lines 122 - 133) <https://reviews.apache.org/r/39191/#comment160039> Same as above, use data provider. lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (lines 200 - 210) <https://reviews.apache.org/r/39191/#comment160040> Data provider. lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (lines 232 - 242) <https://reviews.apache.org/r/39191/#comment160041> Use data provider. lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java (lines 262 - 272) <https://reviews.apache.org/r/39191/#comment160042> Data providers. You can look at org.apache.lens.cube.metadata.TestTimePartition and org.apache.lens.cube.metadata.UpdatePeriodTest for examples. - Rajat Khandelwal On Oct. 13, 2015, 4:57 a.m., Gabor Liptak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39191/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2015, 4:57 a.m.) > > > Review request for lens. > > > Bugs: LENS-615 > https://issues.apache.org/jira/browse/LENS-615 > > > Repository: lens > > > Description > ------- > > LENS-615 Refactoring of testQueryCommands test case > > > Diffs > ----- > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 > > Diff: https://reviews.apache.org/r/39191/diff/ > > > Testing > ------- > > > Thanks, > > Gabor Liptak > >
