----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39314/#review102631 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java (line 231) <https://reviews.apache.org/r/39314/#comment160370> Add driver param in the doc. lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java (line 161) <https://reviews.apache.org/r/39314/#comment160371> doc update lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java (lines 194 - 195) <https://reviews.apache.org/r/39314/#comment160372> `lower(%driverClass%)` doesn't seem valid. Can you do a quick check and verify ? A test case should be enough. lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java (line 144) <https://reviews.apache.org/r/39314/#comment160373> add param here. lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java (line 257) <https://reviews.apache.org/r/39314/#comment160374> add param here. lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java (line 109) <https://reviews.apache.org/r/39314/#comment160375> param update - Rajat Khandelwal On Oct. 14, 2015, 7:06 p.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39314/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 7:06 p.m.) > > > Review request for lens. > > > Bugs: LENS-815 > https://issues.apache.org/jira/browse/LENS-815 > > > Repository: lens > > > Description > ------- > > Added the ability in query list API to filter the queries on driver class. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java > 724e36a > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > 8a2ac19 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > d57812f > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > 96f6aea > > lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java > 17022aa > lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java > 708afe5 > > Diff: https://reviews.apache.org/r/39314/diff/ > > > Testing > ------- > > Yes. Tested the API with driver parameter. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.460 > s] > [INFO] Lens ............................................... SUCCESS [ 4.422 > s] > [INFO] Lens API ........................................... SUCCESS [ 30.327 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 27.110 > s] > [INFO] Lens Cube .......................................... SUCCESS [07:13 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 28.907 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 21.291 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [04:09 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 50.378 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 21.401 > s] > [INFO] Lens Server ........................................ SUCCESS [11:19 > min] > [INFO] Lens client ........................................ SUCCESS [ 47.817 > s] > [INFO] Lens CLI ........................................... SUCCESS [03:46 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 13.728 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 13.644 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [02:01 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.141 > s] > [INFO] Lens Regression .................................... SUCCESS [ 18.077 > s] > [INFO] Lens UI ............................................ SUCCESS [ 47.318 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 34:02 min > [INFO] Finished at: 2015-10-14T16:10:22+05:30 > [INFO] Final Memory: 216M/3029M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Deepak Barr > >
