> On Oct. 15, 2015, 6:31 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java, > > lines 194-195 > > <https://reviews.apache.org/r/39314/diff/2/?file=1098240#file1098240line194> > > > > <p>After we finish LENS-123 (which should happen soon :(), we would > > have the actaul driver name there (Example hive/uh1 or jdbc/mysql1). </p> > > <p>Like will not be required then.</p>
OK. But do you think a user might want to know all the queries fired on jdbc data sources ? I think we can still keep 'like', no ? - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39314/#review102759 ----------------------------------------------------------- On Oct. 14, 2015, 1:36 p.m., Deepak Barr wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39314/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 1:36 p.m.) > > > Review request for lens. > > > Bugs: LENS-815 > https://issues.apache.org/jira/browse/LENS-815 > > > Repository: lens > > > Description > ------- > > Added the ability in query list API to filter the queries on driver class. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java > 724e36a > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > 8a2ac19 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > d57812f > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > 96f6aea > > lens-server/src/main/java/org/apache/lens/server/ui/QueryServiceUIResource.java > 17022aa > lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java > 708afe5 > > Diff: https://reviews.apache.org/r/39314/diff/ > > > Testing > ------- > > Yes. Tested the API with driver parameter. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 3.460 > s] > [INFO] Lens ............................................... SUCCESS [ 4.422 > s] > [INFO] Lens API ........................................... SUCCESS [ 30.327 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 27.110 > s] > [INFO] Lens Cube .......................................... SUCCESS [07:13 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 28.907 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 21.291 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [04:09 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 50.378 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 21.401 > s] > [INFO] Lens Server ........................................ SUCCESS [11:19 > min] > [INFO] Lens client ........................................ SUCCESS [ 47.817 > s] > [INFO] Lens CLI ........................................... SUCCESS [03:46 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 13.728 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 13.644 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [02:01 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 3.141 > s] > [INFO] Lens Regression .................................... SUCCESS [ 18.077 > s] > [INFO] Lens UI ............................................ SUCCESS [ 47.318 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 34:02 min > [INFO] Finished at: 2015-10-14T16:10:22+05:30 > [INFO] Final Memory: 216M/3029M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Deepak Barr > >
