> On Oct. 14, 2015, 10:04 a.m., Rajat Khandelwal wrote: > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java, line > > 451 > > <https://reviews.apache.org/r/39191/diff/3/?file=1097957#file1097957line451> > > > > can you take care of the TODO? > > Gabor Liptak wrote: > Rajat, what is the recommended way to reset this value? This key might or > might not exists, the getConnectionParam() returns a List<String> and there > doesn't seem to be a method to delete a key ... Thanks > > Amareshwari Sriramadasu wrote: > This config is removed now and the setting and unsetting here can be > removed as well.
Removed as in I should delete both set/TODO lines? - Gabor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39191/#review102598 ----------------------------------------------------------- On Oct. 14, 2015, 1:30 a.m., Gabor Liptak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39191/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 1:30 a.m.) > > > Review request for lens. > > > Bugs: LENS-615 > https://issues.apache.org/jira/browse/LENS-615 > > > Repository: lens > > > Description > ------- > > LENS-615 Refactoring of testQueryCommands test case > > > Diffs > ----- > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > 308c036d5e3c52c6892b347d9600cd2d2c7f7fd7 > > Diff: https://reviews.apache.org/r/39191/diff/ > > > Testing > ------- > > > Thanks, > > Gabor Liptak > >
