> On Oct. 25, 2015, 1:54 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line > > 89 > > <https://reviews.apache.org/r/39576/diff/2/?file=1103857#file1103857line89> > > > > Why is this required? There can be more than one session per user. > > Raju Bairishetti wrote: > This map os used for mapping from session handle to user. this was aed to > know who is closing the session. right now we are not mentioning username > while closing session. I can combine session_map ans sessionhandletousermap > if required. > > Amareshwari Sriramadasu wrote: > Please remove this. I dont see any usefulness with this. The caller of > the api could be different from user who opened. > > Raju Bairishetti wrote: > I feel it is required as we need username for for updating(decrementing) > number of sessions for user while closing a session.
getSession(sessionHandle).getLoggedInUser() would give the user of a session. Why is a map required? - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39576/#review103916 ----------------------------------------------------------- On Oct. 23, 2015, 5:51 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39576/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 5:51 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal. > > > Bugs: LENS-833 > https://issues.apache.org/jira/browse/LENS-833 > > > Repository: lens > > > Description > ------- > > Failing the open session operation if user creates more sessions than > configured limit. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > f202603 > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > 0821fe7 > lens-server/src/main/resources/lensserver-default.xml 1e6bd10 > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java > def5683 > > lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java > 8e22837 > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > 18a8c8d > lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java > bc1463f > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 3055ce5 > > lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java > 6f7c216 > src/site/apt/admin/config.apt 3a0678f > > Diff: https://reviews.apache.org/r/39576/diff/ > > > Testing > ------- > > > Thanks, > > Raju Bairishetti > >
