> On Nov. 2, 2015, 10:17 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line
> > 281
> > <https://reviews.apache.org/r/39576/diff/3/?file=1113532#file1113532line281>
> >
> > What if it's already 0?
It will be zero only incase of all the opened sessions for a user are closed.
Seems **(sessionCount > 0) check is not required** as closeSession throws
HiveSQLException in case if user is trying to close the non-existing session. I
was added earlier to make sure user is not misusing this by calling the
closeSession("non-existing").
- Raju
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review104691
-----------------------------------------------------------
On Oct. 31, 2015, 12:24 a.m., Raju Bairishetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
>
> (Updated Oct. 31, 2015, 12:24 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
>
>
> Bugs: LENS-833
> https://issues.apache.org/jira/browse/LENS-833
>
>
> Repository: lens
>
>
> Description
> -------
>
> Failing the open session operation if user creates more sessions than
> configured limit.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/lens-errors.conf a582dc2
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
> 7ee0749
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java
> 0821fe7
> lens-server/src/main/resources/lensserver-default.xml 5f268cb
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java
> def5683
>
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java
> 8e22837
>
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
> ca0fe56
>
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
> 18a8c8d
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java
> bc1463f
>
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java
> 3055ce5
>
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java
> 6f7c216
> src/site/apt/admin/config.apt 88c1489
>
> Diff: https://reviews.apache.org/r/39576/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Raju Bairishetti
>
>
