----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/#review106822 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java (line 98) <https://reviews.apache.org/r/39895/#comment165625> Why does it required copyAST followed by new ASTNode() ? lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java (line 122) <https://reviews.apache.org/r/39895/#comment165651> Can you add comments around whats is done in this method? lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java (line 181) <https://reviews.apache.org/r/39895/#comment165650> Is intelligence required? :) lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java (line 437) <https://reviews.apache.org/r/39895/#comment165649> Can you share cube query and expected union query in a comment, cannot make much from looking at testcase. - Amareshwari Sriramadasu On Nov. 9, 2015, 9:21 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39895/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2015, 9:21 p.m.) > > > Review request for lens. > > > Bugs: LENS-851 > https://issues.apache.org/jira/browse/LENS-851 > > > Repository: lens > > > Description > ------- > > Will do further cleanup and refactoring. Putting this up for an early review. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 450d17202d7a06214ecd997d4bab68fe8351ab3e > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > ea9badd8f0c20644ca2b6e82586fa33f599b781e > lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java > 067a37a29b536a9ff03aae12a396e7bb99f9ba0f > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > 15a98dd941bd7b4cb68369fb553d6722956430d6 > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java > 90058260b36879bbc149c3c33198d3daf1179b36 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > dc11b4ce4598bf6d1dc2dc7ad814bd8757ee34fd > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java > 8da52635c72dfc5f669002f1c8dd1da1b9712b40 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > d7484d83dc0a3f7810ab2109ec882b19b940803b > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > 64b1ac66566239f3a16e55fb5174467940fa0818 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java > 9dcced06b533461c0f2e087709546fe7b66e89c2 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java > 8e35ea9bd9cd727cc25ff011a03d6a38a6f0229f > > Diff: https://reviews.apache.org/r/39895/diff/ > > > Testing > ------- > > Tested for some queries in the test cases themselves. Need to add proper > asserts. > > > Thanks, > > Rajat Khandelwal > >
