> On Nov. 17, 2015, 4:47 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java, > > line 87 > > <https://reviews.apache.org/r/39895/diff/5/?file=1128492#file1128492line87> > > > > Let us do union query writing enabled through a configuration. If not > > enabled, let us throw exception saying requires a union query and it is > > disabled. > > Rajat Khandelwal wrote: > Should this be a server level protection or query level?
query level. Thinking it should be false by default - because currently we are not handling avg and count. Let us document the same saying, union is not handled correctly for non transitive aggregate functions like avg and count. So, should not be enabled for such queries. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/#review106881 ----------------------------------------------------------- On Nov. 17, 2015, 2:30 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39895/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 2:30 p.m.) > > > Review request for lens. > > > Bugs: LENS-851 > https://issues.apache.org/jira/browse/LENS-851 > > > Repository: lens > > > Description > ------- > > Will do further cleanup and refactoring. Putting this up for an early review. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 450d17202d7a06214ecd997d4bab68fe8351ab3e > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > 16e1aa3f3288426e1bc9b823ac8c3d805d54c42f > lens-cube/src/main/java/org/apache/lens/cube/parse/SimpleHQLContext.java > 067a37a29b536a9ff03aae12a396e7bb99f9ba0f > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > 15a98dd941bd7b4cb68369fb553d6722956430d6 > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionHQLContext.java > 90058260b36879bbc149c3c33198d3daf1179b36 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 826f6b63cb4b2c3c3be7846bfbd8d0744d1069ad > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java > 8da52635c72dfc5f669002f1c8dd1da1b9712b40 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 4acd063f4746044afa0e0345faf81adbdda18e0c > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > 64b1ac66566239f3a16e55fb5174467940fa0818 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java > 9dcced06b533461c0f2e087709546fe7b66e89c2 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java > 8e35ea9bd9cd727cc25ff011a03d6a38a6f0229f > > Diff: https://reviews.apache.org/r/39895/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.062s] > [INFO] Lens .............................................. SUCCESS [3.128s] > [INFO] Lens API .......................................... SUCCESS [29.618s] > [INFO] Lens API for server and extensions ................ SUCCESS [23.581s] > [INFO] Lens Cube ......................................... SUCCESS [5:44.708s] > [INFO] Lens DB storage ................................... SUCCESS [20.474s] > [INFO] Lens Query Library ................................ SUCCESS [16.973s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:53.401s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [37.230s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.677s] > [INFO] Lens Server ....................................... SUCCESS [8:16.106s] > [INFO] Lens client ....................................... SUCCESS [38.470s] > [INFO] Lens CLI .......................................... SUCCESS [51.862s] > [INFO] Lens Examples ..................................... SUCCESS [9.145s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.612s] > [INFO] Lens Distribution ................................. SUCCESS [9.499s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:20.974s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.216s] > [INFO] Lens Regression ................................... SUCCESS [14.834s] > [INFO] Lens UI ........................................... SUCCESS [27.308s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 23:21.839s > [INFO] Finished at: Tue Nov 17 14:25:05 UTC 2015 > [INFO] Final Memory: 202M/2273M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
