> On Nov. 20, 2015, 6:26 p.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 445 > > <https://reviews.apache.org/r/40438/diff/1/?file=1129455#file1129455line445> > > > > Should we call this from getTimeline also? Corresponding to the command > > to print fact timeline
printing fact timelines is different. There you're not asking for a timeline for a given combination. There you are asking for all timelines with the given filter. There you provide all parameters as optionals. And in the handler you iterate over all timelines and return those which satisfy the filters. > On Nov. 20, 2015, 6:26 p.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java, > > line 151 > > <https://reviews.apache.org/r/40438/diff/1/?file=1129458#file1129458line151> > > > > Can this be called in failure() itself instead of changing all callers? failure is a static method of in `APIResult`, which is in `lens-api`. `LensException` is in `lens-server-api`, hence can not call. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40438/#review107360 ----------------------------------------------------------- On Nov. 18, 2015, 5:57 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40438/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 5:57 p.m.) > > > Review request for lens. > > > Bugs: LENS-865 > https://issues.apache.org/jira/browse/LENS-865 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/APIResult.java > 06c608afcd53d8f51766f49234c46dd7d3a512b8 > lens-api/src/main/resources/lens-errors.conf > 7526456bf77e26946179d8b52fe7cf75fb175e00 > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > 2119b6489dbd41967e2dcb0f03fa5c933de8ebf1 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > f945e0f44bb4168d07af47194fac805133775d36 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 6a2dc50f1154995b291a5d8bb73c508e7d271504 > > lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java > ac1c5583f9a6ec5ba9f5fc9a8397f0f8bbd40546 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 0748d5b40eeb0ab0a29b35201f13ac1f4a806964 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > e6a798a41b8fa3af6a1496018b3faac1fdf8193e > > Diff: https://reviews.apache.org/r/40438/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
