----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40438/#review107721 -----------------------------------------------------------
Ship it! lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (lines 177 - 178) <https://reviews.apache.org/r/40438/#comment166993> We should try to move other methods also here and do error processing in the Entity . Can be a separate jira. - Amareshwari Sriramadasu On Nov. 23, 2015, 1:54 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40438/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2015, 1:54 p.m.) > > > Review request for lens. > > > Bugs: LENS-865 > https://issues.apache.org/jira/browse/LENS-865 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/APIResult.java > 06c608afcd53d8f51766f49234c46dd7d3a512b8 > lens-api/src/main/resources/lens-errors.conf > f50433a5467d730dca8110a92f56a7e220755b01 > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > 24fb80b08320d4c2fb82385181a9cd196e6b8354 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > f945e0f44bb4168d07af47194fac805133775d36 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 6a2dc50f1154995b291a5d8bb73c508e7d271504 > > lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java > ac1c5583f9a6ec5ba9f5fc9a8397f0f8bbd40546 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 0748d5b40eeb0ab0a29b35201f13ac1f4a806964 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > e6a798a41b8fa3af6a1496018b3faac1fdf8193e > > Diff: https://reviews.apache.org/r/40438/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.359s] > [INFO] Lens .............................................. SUCCESS [3.260s] > [INFO] Lens API .......................................... SUCCESS [23.552s] > [INFO] Lens API for server and extensions ................ SUCCESS [21.112s] > [INFO] Lens Cube ......................................... SUCCESS [5:40.038s] > [INFO] Lens DB storage ................................... SUCCESS [19.195s] > [INFO] Lens Query Library ................................ SUCCESS [16.002s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:47.294s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [38.855s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [17.048s] > [INFO] Lens Server ....................................... SUCCESS [7:52.723s] > [INFO] Lens client ....................................... SUCCESS [36.964s] > [INFO] Lens CLI .......................................... SUCCESS [50.909s] > [INFO] Lens Examples ..................................... SUCCESS [8.416s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.459s] > [INFO] Lens Distribution ................................. SUCCESS [9.133s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:22.007s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.824s] > [INFO] Lens Regression ................................... SUCCESS [14.248s] > [INFO] Lens UI ........................................... SUCCESS [27.306s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 22:34.839s > [INFO] Finished at: Mon Nov 23 13:48:16 UTC 2015 > [INFO] Final Memory: 220M/2548M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajat Khandelwal > >
