[
https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15028541#comment-15028541
]
Rajat Khandelwal commented on LENS-885:
---------------------------------------
Created https://reviews.apache.org/r/40739/
> Cleanup of Cube test cases
> --------------------------
>
> Key: LENS-885
> URL: https://issues.apache.org/jira/browse/LENS-885
> Project: Apache Lens
> Issue Type: Sub-task
> Components: build
> Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
>
> * Some functions are wrongly placed. e.g. DateUtil.getCeilDate(date,
> updatePeriod) can be better expressed as updatePeriod.getCeilDate(date).
> * Date parsing from query can be cached
> * There is a bloat of Date variables in CubeTestSetup, organize them and only
> keep named variables for the most used ones
> * Unify time range clause creation across test cases. Right now, tests create
> time ranges as and when needed. Remove repetition and redundancies.
> * Correct names to variables
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
