[
https://issues.apache.org/jira/browse/LENS-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052822#comment-15052822
]
Hudson commented on LENS-885:
-----------------------------
SUCCESS: Integrated in Lens-Commit-Java8 #65 (See
[https://builds.apache.org/job/Lens-Commit-Java8/65/])
LENS-885: Cleanup of Cube test cases (rajatgupta59: rev
7c7c86daed2e9907bda92f5ed29e73ed99a9a726)
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java
*
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java
* lens-cube/src/main/java/org/apache/lens/cube/metadata/UpdatePeriod.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRange.java
* lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java
*
lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestDateUtil.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
*
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
*
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java
*
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
* lens-cube/src/main/java/org/apache/lens/cube/metadata/TimePartitionRange.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/DateUtil.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionContext.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java
* lens-server/src/main/java/org/apache/lens/server/query/QueryResultPurger.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java
* lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryMetrics.java
* lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactHQLContext.java
* lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java
*
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestORTimeRangeWriter.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriter.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestStorageUtil.java
* lens-cube/src/test/java/org/apache/lens/cube/metadata/TestDateUtil.java
*
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
* lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java
* lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java
* lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java
* lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeExtractor.java
> Cleanup of Cube test cases
> --------------------------
>
> Key: LENS-885
> URL: https://issues.apache.org/jira/browse/LENS-885
> Project: Apache Lens
> Issue Type: Sub-task
> Components: build
> Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Fix For: 2.5
>
> Attachments: LENS-885.03.patch, LENS-885.04.patch
>
>
> * Some functions are wrongly placed. e.g. DateUtil.getCeilDate(date,
> updatePeriod) can be better expressed as updatePeriod.getCeilDate(date).
> * Date parsing from query can be cached
> * There is a bloat of Date variables in CubeTestSetup, organize them and only
> keep named variables for the most used ones
> * Unify time range clause creation across test cases. Right now, tests create
> time ranges as and when needed. Remove repetition and redundancies.
> * Correct names to variables
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
