[
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050425#comment-15050425
]
Rajat Khandelwal commented on LENS-879:
---------------------------------------
I believe that attaching patch just for the reason of checking pre-commit
results is not a good idea. That would be a misuse of pre-commit job. As a
contributor you should be confident about the validity of your patch. I believe
the Pre-commit job is to help the committers. The committers have to be sure
that the patch is valid and is not breaking anything before committing.
Pre-commit job is automating that manual effort.
We don't attach patches with every revision posted in reviewboard because
* too much noise in email
* It's anyway duplicate of something present somewhere else. Whatever be the
use of the patch file, can be obtained from reviewboard.
* Once committed, earlier patches are useless. I'd say even the committed patch
is useless, but the "degree of uselessness" is more :P. The patch that is
uploaded on jira is supposed to be a snapshot of the approved patch on
reviewboard in case more patches are added on reviewboard later.
** It's a previous version
** Of a useless file
** While being present somewhere else too
> Base framework for Scheduler.
> -----------------------------
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
> Issue Type: Sub-task
> Components: server
> Reporter: Ajay Yadava
> Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch,
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
