[
https://issues.apache.org/jira/browse/LENS-879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15050498#comment-15050498
]
Ajay Yadava commented on LENS-879:
----------------------------------
Thanks for the detailed response, appreciate it. My intention was not to
propose a change in the workflow but just to get some clarifications. Just for
a fresh perspective I will put my views here:
I think instead of making the build a committer's prerogative, opening it for
contributors will be much helpful. I think same is reflected when most Apache
Projects run it on Patch Available queue and not on JIRAs which have "Ship It"
or "+1".
It is also not about contributor's confidence in patch, uploading your work in
open for criticism from everyone requires more confidence.
1. It also provides a sandbox environment for contributors to test their
changes with the latest of the trunk. It might be the case that the patch
passed on my machine, but fails on Jenkins because of some timing issues in
tests. Discovering that issue early is very useful as it might require non
trivial changes in design and will cause another round of review from scratch
for my patch.
2. It is also not useless as it provides a history of changes over time. If
duplication is the concern then probably switching to github workflow for
apache is a much better model.
3. It forces some idiosyncratic workflows for LENS e.g. the issues for which
the patch is available doesn't have status as "Patch Available". It can also
eliminate the need to copy paste the build status and also allow committers to
be doubly sure about the quality of patch.
All that said, these are just my personal views. As I said earlier also,
intention was to just get some clarifications on build/metadata and not propose
a new workflow. I am happy to stop posting my patches on JIRA and save some
clicks :)
> Base framework for Scheduler.
> -----------------------------
>
> Key: LENS-879
> URL: https://issues.apache.org/jira/browse/LENS-879
> Project: Apache Lens
> Issue Type: Sub-task
> Components: server
> Reporter: Ajay Yadava
> Assignee: Ajay Yadava
> Attachments: LENS-879-v1.patch, LENS-879-v2.patch, LENS-879-v3.patch,
> LENS-879-v4.patch, LENS-879-v5.patch, LENS-879.patch
>
>
> Add interfaces for scheduler service and xsd for job.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
