----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41506/#review111459 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java (line 882) <https://reviews.apache.org/r/41506/#comment171682> Should we have just one retry by default ? lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java (line 111) <https://reviews.apache.org/r/41506/#comment171664> can we log this as error ? lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java (line 162) <https://reviews.apache.org/r/41506/#comment171665> This can be a static string. We can create it once and reuse. Same can be follwed for other instances too. lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java (line 207) <https://reviews.apache.org/r/41506/#comment171666> driverendtime can be skipped from ordering construct. lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 816) <https://reviews.apache.org/r/41506/#comment171679> Will the relaunch we immediate or it ll have some time gap? lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 817) <https://reviews.apache.org/r/41506/#comment171675> Can we also log Relauch Failed in else part or in reLaunchFailedQuery(). lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 830) <https://reviews.apache.org/r/41506/#comment171767> Shall we let the driver decide on number of re-tries ? It can be diff for Hive and JDBC. Eventually (in future) it can even differ based on error type. lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 833) <https://reviews.apache.org/r/41506/#comment171673> Can we add an info log that query is being relaunched. lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1157) <https://reviews.apache.org/r/41506/#comment171676> Log msg needs to be updated. May be separate try catch for each table creation . Also log level should be upgraded to error lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 1853) <https://reviews.apache.org/r/41506/#comment171678> Should we store numOfAttempts in finishedQueries table? If the value is zero, we need not check failed attempts table at all. Also admin can query finished query table and gets attempts statistics easily. Or is there a way to add a new Query in lensServerDao which joins finished queries table with failed attempts and gets the result in one hop. It can be messy though. - Puneet Gupta On Dec. 21, 2015, 9:15 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41506/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2015, 9:15 a.m.) > > > Review request for lens. > > > Bugs: LENS-899 > https://issues.apache.org/jira/browse/LENS-899 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java > 91cbe391a2bc81edae587b268104940122993243 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 88e5a01e3f08b12ff9e872d7412496dfc70ea626 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java > ed1fc43ab6e6ef8c34c5c2510cd5f5333ca16179 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java > 79d8bf1e8f9798714d14e5a0336e24a148c4ca27 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java > 3d38ddd2dfe596b348bb48807aac5caeab5e936a > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FailedAttempt.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java > a57a6e4ed1827ee5094cbfd423c183766d9dc5f4 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 1269e45ff7e5b9392108e338735b9774fb8a2686 > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > d8e654d72989d7a8f9334adc81b82a9e0810ee39 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 2dff9afeb384738fa21ef7381cb5a54e3c02165a > > Diff: https://reviews.apache.org/r/41506/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
