> On Dec. 30, 2015, 2:31 p.m., Puneet Gupta wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FailedAttempt.java, > > line 34 > > <https://reviews.apache.org/r/41506/diff/1-2/?file=1173731#file1173731line34> > > > > can this use attempt number for comparison ? Also who is using this > > comparator now ?
1. This comparator is not being used. 2. I don't want to store its index in the list inside the object. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41506/#review112292 ----------------------------------------------------------- On Dec. 24, 2015, 4:06 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41506/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2015, 4:06 p.m.) > > > Review request for lens. > > > Bugs: LENS-899 > https://issues.apache.org/jira/browse/LENS-899 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java > 91cbe391a2bc81edae587b268104940122993243 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 88e5a01e3f08b12ff9e872d7412496dfc70ea626 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java > ed1fc43ab6e6ef8c34c5c2510cd5f5333ca16179 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java > 79d8bf1e8f9798714d14e5a0336e24a148c4ca27 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java > 3d38ddd2dfe596b348bb48807aac5caeab5e936a > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FailedAttempt.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java > a57a6e4ed1827ee5094cbfd423c183766d9dc5f4 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 1269e45ff7e5b9392108e338735b9774fb8a2686 > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > d8e654d72989d7a8f9334adc81b82a9e0810ee39 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 2dff9afeb384738fa21ef7381cb5a54e3c02165a > > Diff: https://reviews.apache.org/r/41506/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
