----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41538/#review111826 -----------------------------------------------------------
lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcConnection.java (line 60) <https://reviews.apache.org/r/41538/#comment172095> Why is this swapped? lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDatabaseMetaData.java (lines 38 - 40) <https://reviews.apache.org/r/41538/#comment172098> Please use explicit `List<T>` lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDatabaseMetaData.java (lines 48 - 49) <https://reviews.apache.org/r/41538/#comment172099> use proper generic type in `List<T>` lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDatabaseMetaData.java (lines 63 - 64) <https://reviews.apache.org/r/41538/#comment172100> use proper generic type in `List<T>` lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDatabaseMetaData.java (lines 75 - 100) <https://reviews.apache.org/r/41538/#comment172096> suggestion: ``` List<String> columns Lists.newArrayList( new ResultColumn("TABLE_CAT", ResultColumnType.STRING), new ResultColumn("TABLE_SCHEM", ResultColumnType.STRING), new ResultColumn("TABLE_NAME", ResultColumnType.STRING), new ResultColumn("COLUMN_NAME", ResultColumnType.STRING), new ResultColumn("DATA_TYPE", ResultColumnType.INT), new ResultColumn("TYPE_NAME", ResultColumnType.STRING), new ResultColumn("COLUMN_SIZE", ResultColumnType.INT), new ResultColumn("BUFFER_LENGTH", ResultColumnType.INT), new ResultColumn("DECIMAL_DIGITS", ResultColumnType.INT), new ResultColumn("NUM_PREC_RADIX", ResultColumnType.INT), new ResultColumn("NULLABLE", ResultColumnType.INT), new ResultColumn("REMARKS", ResultColumnType.STRING), new ResultColumn("COLUMN_DEF", ResultColumnType.STRING), new ResultColumn("SQL_DATA_TYPE", ResultColumnType.INT), new ResultColumn("SQL_DATETIME_SUB", ResultColumnType.INT), new ResultColumn("CHAR_OCTET_LENGTH", ResultColumnType.INT), new ResultColumn("ORDINAL_POSITION", ResultColumnType.INT), new ResultColumn("IS_NULLABLE", ResultColumnType.STRING), new ResultColumn("SCOPE_CATALOG", ResultColumnType.STRING), new ResultColumn("SCOPE_SCHEMA", ResultColumnType.STRING), new ResultColumn("SCOPE_TABLE", ResultColumnType.STRING), new ResultColumn("SOURCE_DATA_TYPE", ResultColumnType.SMALLINT), new ResultColumn("IS_AUTOINCREMENT", ResultColumnType.STRING), new ResultColumn("IS_GENERATEDCOLUMN", ResultColumnType.STRING) ); ``` lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDatabaseMetaData.java (line 104) <https://reviews.apache.org/r/41538/#comment172097> Please use List<String> lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDatabaseMetaData.java (line 150) <https://reviews.apache.org/r/41538/#comment172101> use proper generic type in `List<T>` lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDatabaseMetaData.java (line 178) <https://reviews.apache.org/r/41538/#comment172102> http://stackoverflow.com/questions/4658867/why-does-arrays-aslist-return-its-own-arraylist-implementation `Arrays.asList(new Object[n])` and `new ArrayList(n)` have the same data usages, but the former is an fixed size array list without the `remove` and `add` functionality. First one should not be used when there is even a slight possibility that the caller to whom you're returning the list might want to `add` or `remove` from the list. Please take a look at all such instances in your code and change wherever needed. - Rajat Khandelwal On Dec. 18, 2015, 11:56 a.m., piyush mukati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41538/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 11:56 a.m.) > > > Review request for lens. > > > Bugs: LENS-898 > https://issues.apache.org/jira/browse/LENS-898 > > > Repository: lens > > > Description > ------- > > implementing java.sql.Connection#getMetaData. it returns > java.sql.DatabaseMetaData object which is used to get meta details about the > database. > Currently getMetaData in Lens Jdbc client is returning null > > > Diffs > ----- > > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcConnection.java > 9ad31ee > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDatabaseMetaData.java > PRE-CREATION > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcResultSet.java > ee5ed4d > > Diff: https://reviews.apache.org/r/41538/diff/ > > > Testing > ------- > > [INFO] ----------------------------------------------------------------------- > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.512 > s] > [INFO] Lens ............................................... SUCCESS [ 4.469 > s] > [INFO] Lens API ........................................... SUCCESS [ 19.753 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 17.002 > s] > [INFO] Lens Cube .......................................... SUCCESS [13:05 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 18.309 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 13.482 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:39 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 35.239 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 18.504 > s] > [INFO] Lens Server ........................................ SUCCESS [15:38 > min] > [INFO] Lens client ........................................ SUCCESS [ 40.713 > s] > [INFO] Lens CLI ........................................... SUCCESS [ 57.885 > s] > [INFO] Lens Examples ...................................... SUCCESS [ 10.165 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.958 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 11.911 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:59 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 6.344 > s] > [INFO] Lens Regression .................................... SUCCESS [ 16.850 > s] > [INFO] Lens UI ............................................ SUCCESS [ 3.748 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 38:02 min > [INFO] Finished at: 2015-12-18T11:21:37+05:30 > [INFO] Final Memory: 144M/835M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > piyush mukati > >
