> On Dec. 30, 2015, 10:57 a.m., Puneet Gupta wrote: > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDatabaseMetaData.java, > > lines 118-119 > > <https://reviews.apache.org/r/41538/diff/1/?file=1170547#file1170547line118> > > > > Can you explain this part more ? What inputs are you expecting in > > schemaPattern that this translation is required > > piyush mukati wrote: > Hi puneet, As per jdbc defenetion of the method getSchemas, it expects > sql like regex.
Currently lens meta APIs dont support regex filtering. I have provided some support in JDBC client whereever it is possible. - piyush ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41538/#review112304 ----------------------------------------------------------- On Jan. 4, 2016, 6:23 a.m., piyush mukati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41538/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 6:23 a.m.) > > > Review request for lens. > > > Bugs: LENS-898 > https://issues.apache.org/jira/browse/LENS-898 > > > Repository: lens > > > Description > ------- > > implementing java.sql.Connection#getMetaData. it returns > java.sql.DatabaseMetaData object which is used to get meta details about the > database. > Currently getMetaData in Lens Jdbc client is returning null > > > Diffs > ----- > > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcConnection.java > 9ad31ee > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcDatabaseMetaData.java > PRE-CREATION > > lens-client/src/main/java/org/apache/lens/client/jdbc/LensJdbcResultSet.java > ee5ed4d > > Diff: https://reviews.apache.org/r/41538/diff/ > > > Testing > ------- > > [INFO] ----------------------------------------------------------------------- > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.512 > s] > [INFO] Lens ............................................... SUCCESS [ 4.469 > s] > [INFO] Lens API ........................................... SUCCESS [ 19.753 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 17.002 > s] > [INFO] Lens Cube .......................................... SUCCESS [13:05 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 18.309 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 13.482 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [02:39 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [ 35.239 > s] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 18.504 > s] > [INFO] Lens Server ........................................ SUCCESS [15:38 > min] > [INFO] Lens client ........................................ SUCCESS [ 40.713 > s] > [INFO] Lens CLI ........................................... SUCCESS [ 57.885 > s] > [INFO] Lens Examples ...................................... SUCCESS [ 10.165 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 0.958 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 11.911 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:59 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 6.344 > s] > [INFO] Lens Regression .................................... SUCCESS [ 16.850 > s] > [INFO] Lens UI ............................................ SUCCESS [ 3.748 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 38:02 min > [INFO] Finished at: 2015-12-18T11:21:37+05:30 > [INFO] Final Memory: 144M/835M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > piyush mukati > >
