----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41671/#review111834 -----------------------------------------------------------
lens-api/src/main/resources/cube-0.1.xsd (line 399) <https://reviews.apache.org/r/41671/#comment172105> let's remove "reference Specification" now, since it's no longer ref_spec. lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java (lines 100 - 109) <https://reviews.apache.org/r/41671/#comment172106> The addition of `throws` seems redundant. lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java (line 171) <https://reviews.apache.org/r/41671/#comment172107> Can we wrap HiveException in LensException? lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java (line 67) <https://reviews.apache.org/r/41671/#comment172108> throws seems redundant lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java (lines 89 - 99) <https://reviews.apache.org/r/41671/#comment172109> If the above throws is redundant, these can also be removed. lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 582) <https://reviews.apache.org/r/41671/#comment172110> Whrerever we're changing `throws HiveException` to `throws HiveException and LensException`, it'd be good to look inside and try to wrap `HiveException` in `LensException` wherever possible. lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAttribute.java (line 116) <https://reviews.apache.org/r/41671/#comment172111> Any changes in this file other than renaming? Seems like reviewboard is showing this file as deleted and re-added. lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 746) <https://reviews.apache.org/r/41671/#comment172115> Do we need a log or something in else? lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 747) <https://reviews.apache.org/r/41671/#comment172114> Not assuming anymore. lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java <https://reviews.apache.org/r/41671/#comment172113> Seems the patch doesn't apply on master now. Probably conflicts with LENS-552. lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java <https://reviews.apache.org/r/41671/#comment172116> +1 lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java (lines 73 - 82) <https://reviews.apache.org/r/41671/#comment172119> Do we have test cases around this? lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java (lines 871 - 896) <https://reviews.apache.org/r/41671/#comment172122> Looking at all this I feel we can invent a one-to one `toString` and `fromString` pair for priting and parsing join chains. Hopefully I'll be able to do that in LENS-791 It seems that from a lot of places, `throws LensException` can be removed. Have pointed out a few but I think mostly they are propagation of 1 or 2 misplaced `throws` statements. Please See if they can be removed. - Rajat Khandelwal On Dec. 23, 2015, 11:12 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41671/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2015, 11:12 a.m.) > > > Review request for lens. > > > Bugs: LENS-735 > https://issues.apache.org/jira/browse/LENS-735 > > > Repository: lens > > > Description > ------- > > Changes include the following : > > - Remove the option to specify TableReferences for reference in xsd. Now we > accept only chain ref columns > - Updated the same in all corresponding classes > - Removed unnecessary code from JoinResolver. Also did some refactoring for > join related classes > - Updated existing tests to use chain ref columns > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 4092133 > lens-cli/src/test/resources/sample-cube.xml d72d279 > lens-cli/src/test/resources/test-dimension.xml 6eb3d31 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java > 88c9ee8 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > da3a7e5 > lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java > bd4ae57 > lens-cube/src/main/java/org/apache/lens/cube/metadata/ColumnMeasure.java > 5fda721 > lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java f09da37 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java > b04532f > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeDimAttribute.java > 26c24de > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeDimensionTable.java > cd80d64 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > dd0adb7 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMeasure.java > d5fc0e7 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > e7550ca > lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java > 681aa7b > lens-cube/src/main/java/org/apache/lens/cube/metadata/Dimension.java > 27cbc30 > lens-cube/src/main/java/org/apache/lens/cube/metadata/ExprColumn.java > da87e31 > lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java > c4c3e9b > > lens-cube/src/main/java/org/apache/lens/cube/metadata/HierarchicalDimAttribute.java > 698a390 > lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java > 6250905 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java > c51b489 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAttribute.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java > fa230ef > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603 > lens-cube/src/main/java/org/apache/lens/cube/metadata/join/JoinPath.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/metadata/join/TableRelationship.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java > 9472506 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 4034a54 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > a576f3a > lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java > ab7a6d8 > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 7cea7d5 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinClause.java d9a8249 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java > 1385584 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinTree.java 5a294af > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 67b3f40 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java > 1a83d09 > > lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinTree.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinUtils.java > PRE-CREATION > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 0fef13f > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 3f01dbe > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 9a08735 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > d9e442d > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java > d69635d > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java > b7372f1 > lens-examples/src/main/resources/sales-cube.xml 7ec2ec7 > lens-examples/src/main/resources/sample-cube.xml 7b784ea > lens-examples/src/main/resources/sample-db-only-dimension.xml 4c6bec6 > lens-examples/src/main/resources/sample-dimension.xml 9b97da7 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 817c84c > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > e0c0923 > lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java > 03b8d43 > lens-storage-db/src/test/java/org/apache/lens/storage/db/TestDBStorage.java > 92a0027 > > Diff: https://reviews.apache.org/r/41671/diff/ > > > Testing > ------- > > Few more tests in lens-cube are failing. Will fix and upload next patch. > > Pending: > - Verify examples > - and full test suite. > > > Thanks, > > Amareshwari Sriramadasu > >
