-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41671/
-----------------------------------------------------------

(Updated Jan. 6, 2016, 4:38 p.m.)


Review request for lens.


Bugs: LENS-735
    https://issues.apache.org/jira/browse/LENS-735


Repository: lens


Description
-------

Changes include the following :

- Remove the option to specify TableReferences for reference in xsd. Now we 
accept only chain ref columns
- Updated the same in all corresponding classes
- Removed unnecessary code from JoinResolver. Also did some refactoring for 
join related classes
- Updated existing tests to use chain ref columns


Diffs (updated)
-----

  lens-api/src/main/resources/cube-0.1.xsd 4092133 
  lens-api/src/main/resources/lens-errors.conf c7ccea1 
  lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 
42c6bae 
  lens-cli/src/test/resources/cube_with_no_weight_facts.xml 263ca88 
  lens-cli/src/test/resources/sample-cube.xml d72d279 
  lens-cli/src/test/resources/test-dimension.xml 6eb3d31 
  lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java 
68cd80b 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java 
88c9ee8 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 
da3a7e5 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/Cube.java f09da37 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeColumn.java b04532f 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeDimensionTable.java 
cd80d64 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 
dd0adb7 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 
e7550ca 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/DerivedCube.java 
681aa7b 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/Dimension.java 27cbc30 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java 6250905 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java
 c51b489 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAttribute.java
 PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/SchemaGraph.java 
fa230ef 
  lens-cube/src/main/java/org/apache/lens/cube/metadata/join/JoinPath.java 
PRE-CREATION 
  
lens-cube/src/main/java/org/apache/lens/cube/metadata/join/TableRelationship.java
 PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/AutoJoinContext.java 
7f13c6c 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateDim.java 64dff16 
  lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java 
1fd1d17 
  
lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java 
5c8bd84 
  lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java b253b94 
  lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java 
ab7a6d8 
  lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 6c3d4c3 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinClause.java d9a8249 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinResolver.java de3a16e 
  lens-cube/src/main/java/org/apache/lens/cube/parse/JoinTree.java 5a294af 
  lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java 67b3f40 
  lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
1a83d09 
  lens-cube/src/main/java/org/apache/lens/cube/parse/join/AutoJoinContext.java 
PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinClause.java 
PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinTree.java 
PRE-CREATION 
  lens-cube/src/main/java/org/apache/lens/cube/parse/join/JoinUtils.java 
PRE-CREATION 
  
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
 0fef13f 
  lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java ad20ae1 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java
 ff7c15f 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
5b44f95 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
f02cdb0 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java
 af9daad 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionContext.java 
f48e1b7 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java 
e77f919 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java 
d9e442d 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java 
d69635d 
  lens-cube/src/test/java/org/apache/lens/cube/parse/TestRewriterPlan.java 
5a072e4 
  
lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java
 b7372f1 
  lens-examples/src/main/resources/cube-queries.sql 13c5204 
  lens-examples/src/main/resources/customer.xml 920fd49 
  lens-examples/src/main/resources/dimension-queries.sql 7aff639 
  lens-examples/src/main/resources/sales-cube.xml 7ec2ec7 
  lens-examples/src/main/resources/sample-cube.xml 7b784ea 
  lens-examples/src/main/resources/sample-db-only-dimension.xml 4c6bec6 
  lens-examples/src/main/resources/sample-dimension.xml 9b97da7 
  lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
817c84c 
  
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
 e0c0923 
  lens-storage-db/src/test/java/org/apache/lens/storage/db/TestDBStorage.java 
92a0027 

Diff: https://reviews.apache.org/r/41671/diff/


Testing (updated)
-------

Verified Examples:
--------------------
Successful queries 148 out of 148queries
Total time for running examples(in millis) :1131693

Test suite:
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.874s]
[INFO] Lens .............................................. SUCCESS [3.004s]
[INFO] Lens API .......................................... SUCCESS [26.941s]
[INFO] Lens API for server and extensions ................ SUCCESS [23.942s]
[INFO] Lens Cube ......................................... SUCCESS [11:32.705s]
[INFO] Lens DB storage ................................... SUCCESS [20.237s]
[INFO] Lens Query Library ................................ SUCCESS [16.431s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:54.221s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [38.222s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [17.981s]
[INFO] Lens Server ....................................... SUCCESS [9:54.096s]
[INFO] Lens client ....................................... SUCCESS [35.877s]
[INFO] Lens CLI .......................................... SUCCESS [55.719s]
[INFO] Lens Examples ..................................... SUCCESS [8.875s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.710s]
[INFO] Lens Distribution ................................. SUCCESS [8.610s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:25.924s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.247s]
[INFO] Lens Regression ................................... SUCCESS [14.595s]
[INFO] Lens UI ........................................... SUCCESS [29.712s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:52.906s
[INFO] Finished at: Wed Jan 06 16:35:42 UTC 2016
[INFO] Final Memory: 182M/1162M
[INFO] ------------------------------------------------------------------------


Thanks,

Amareshwari Sriramadasu

Reply via email to