----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39576/#review114953 -----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java (line 25) <https://reviews.apache.org/r/39576/#comment175787> Did not like the fact we are doing a copy of Response.Status. We should be see if there is anyother way to achieve this. lens-server/src/main/resources/lensserver-default.xml (line 812) <https://reviews.apache.org/r/39576/#comment175788> Please document what happens if it exceeds. lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java (line 125) <https://reviews.apache.org/r/39576/#comment175789> set for debugging? lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java (line 547) <https://reviews.apache.org/r/39576/#comment175790> mp not used ? - Amareshwari Sriramadasu On Jan. 13, 2016, 12:11 p.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39576/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2016, 12:11 p.m.) > > > Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal. > > > Bugs: LENS-833 > https://issues.apache.org/jira/browse/LENS-833 > > > Repository: lens > > > Description > ------- > > Failing the open session operation if user creates more sessions than > configured limit. > > Created LensHttpStatus for adding new status codes in the Response class. > Both Status from Response class and LensHttpStatus implements StatusType > interface. > Changed teh parameter type to StatusType to make it generic > > > Diffs > ----- > > > lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java > 741630b > lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409 > lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java > PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java > 238f9e6 > lens-api/src/main/resources/lens-errors.conf 9087fcd > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > 558e97f > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 43d0722 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > 32ed7b0 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > 160699b > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > 30f4ec1 > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > 448d0f6 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java > 9fce233 > lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java > f4b043e > lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java > e5f11f2 > lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java > 8bccac2 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > a3dbfc0 > > lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java > a1ffeb6 > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > 0821fe7 > > lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java > dc20f0f > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > 3ba5edd > lens-server/src/main/resources/lensserver-default.xml cac641a > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > 8f52ddd > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java > 75f21e1 > > lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java > 8e22837 > > lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java > 4d4f137 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 925fc86 > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > 6f8886c > lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java > 01e846a > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > c5d75de > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 3055ce5 > > lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java > 6f7c216 > lens-server/src/test/resources/lens-site.xml 9cb4a6f > src/site/apt/admin/config.apt 54f827e > src/site/apt/admin/session-config.apt 05a2c2c > > Diff: https://reviews.apache.org/r/39576/diff/ > > > Testing > ------- > > > Thanks, > > Raju Bairishetti > >
