----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39576/#review113594 -----------------------------------------------------------
lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java (line 66) <https://reviews.apache.org/r/39576/#comment174334> Let us fill this TODO. Seems anything greater than 417 cannot be created from Status.fromStatusCode, let us create explicitly for them. lens-api/src/main/resources/lens-errors.conf (line 102) <https://reviews.apache.org/r/39576/#comment174335> Should we pass user name as param here? lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java (line 118) <https://reviews.apache.org/r/39576/#comment174336> Arent both the commands using the same client? lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (line 91) <https://reviews.apache.org/r/39576/#comment174337> Can you add on what each map is doing? lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (line 107) <https://reviews.apache.org/r/39576/#comment174338> Why is this class required? lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (line 155) <https://reviews.apache.org/r/39576/#comment174339> Add constructor with username, instead of setter. lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (lines 199 - 202) <https://reviews.apache.org/r/39576/#comment174340> Not inside synchronized block ? lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (lines 289 - 292) <https://reviews.apache.org/r/39576/#comment174341> Not synchronized? lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java (line 28) <https://reviews.apache.org/r/39576/#comment174342> Typo in error code lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java (line 519) <https://reviews.apache.org/r/39576/#comment174343> Add test at resource level as well. lens-server/src/test/resources/lens-site.xml (line 192) <https://reviews.apache.org/r/39576/#comment174344> Why 20? It should be lesser than the default as well. - Amareshwari Sriramadasu On Jan. 5, 2016, 12:42 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39576/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2016, 12:42 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal. > > > Bugs: LENS-833 > https://issues.apache.org/jira/browse/LENS-833 > > > Repository: lens > > > Description > ------- > > Failing the open session operation if user creates more sessions than > configured limit. > > > Diffs > ----- > > > lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java > 741630b > lens-api/src/main/resources/lens-errors.conf 06960a0 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > 558e97f > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 43d0722 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > 32ed7b0 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > 42c6bae > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > 30f4ec1 > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > 448d0f6 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java > 9fce233 > lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java > f4b043e > lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java > d453803 > lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java > 8bccac2 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 88e5a01 > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > 0821fe7 > > lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java > dc20f0f > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > 3ba5edd > lens-server/src/main/resources/lensserver-default.xml cac641a > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java > 75f21e1 > > lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java > 8e22837 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > e0c0923 > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > 69c3f46 > lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java > 01e846a > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > 3055ce5 > > lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java > 6f7c216 > lens-server/src/test/resources/lens-site.xml 9cb4a6f > src/site/apt/admin/config.apt 54f827e > > Diff: https://reviews.apache.org/r/39576/diff/ > > > Testing > ------- > > > Thanks, > > Raju Bairishetti > >
