> On Feb. 29, 2016, 4:15 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line > > 318 > > <https://reviews.apache.org/r/39576/diff/10/?file=1273670#file1273670line318> > > > > Shouldnt we remove from map when count reaches zero?
This code can not be reachable when there are no active sessions for that user. closeSession will throw an exception if user is trying to a session which is not exists. Count zero here indicates that there are no active sessions. > On Feb. 29, 2016, 4:15 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java, > > line 51 > > <https://reviews.apache.org/r/39576/diff/10/?file=1273676#file1273676line51> > > > > Error wont not be coming in Data. Why is this change done? LensErrorTO is coming as part of Data with my changes. I had seen some issues with LensAPIResult composedOf invocations. LensAPIResult.java: **Before/After the changes the follwoing method was invoked from other methods:** public static <DATA> LensAPIResult<DATA> composedOf(final String apiVersion, final String id, @NonNull final DATA data, @NonNull final Response.StatusType httpStatusCode) { return new LensAPIResult<>(apiVersion, id, data, null, httpStatusCode); } **After/Before StatusType changes this method getting called:** public static LensAPIResult<NoResultData> composedOf( final String apiVersion, final String id, @NonNull final LensErrorTO lensErrorTO, @NonNull final Status httpStatusCode) { return new LensAPIResult<>(apiVersion, id, null, lensErrorTO, httpStatusCode); } Did not remember properly. I will check it now. - Raju ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39576/#review121185 ----------------------------------------------------------- On Feb. 28, 2016, 11:43 p.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39576/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2016, 11:43 p.m.) > > > Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal. > > > Bugs: LENS-833 > https://issues.apache.org/jira/browse/LENS-833 > > > Repository: lens > > > Description > ------- > > Failing the open session operation if user creates more sessions than > configured limit. > > Created LensHttpStatus for adding new status codes in the Response class. > Both Status from Response class and LensHttpStatus implements StatusType > interface. > Changed teh parameter type to StatusType to make it generic > > > Diffs > ----- > > > lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java > 741630b > lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409 > lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java > PRE-CREATION > lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java > 238f9e6 > lens-api/src/main/resources/lens-errors.conf 09b221f > > lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java > 558e97f > lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java > 97ca2c8 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java > 32ed7b0 > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java > 45555f4 > > lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java > bea128b > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java > 1454e5f > > lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java > 9fce233 > lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java > f4b043e > lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java > e5f11f2 > lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java > a178296 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 1b7d0f9 > > lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java > a1ffeb6 > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > 0821fe7 > > lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java > dc20f0f > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > ac77418 > lens-server/src/main/resources/lensserver-default.xml a711d03 > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java > caf968a > > lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java > 8e22837 > > lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java > 4d4f137 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > a541e9b > > lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java > 30f7aff > lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java > a5ee5cc > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 699fa68 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java > bde7b9b > > lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java > be87e65 > lens-server/src/test/resources/lens-site.xml c3187a8 > src/site/apt/admin/config.apt fb15d83 > > Diff: https://reviews.apache.org/r/39576/diff/ > > > Testing > ------- > > > Thanks, > > Raju Bairishetti > >
