> On Feb. 29, 2016, 12:44 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java, line 
> > 218
> > <https://reviews.apache.org/r/39576/diff/10/?file=1273670#file1273670line218>
> >
> >     Seems the update is not happening upon restore. We need to take care of 
> > that as well.

We are already handling this case.

 public void restoreSession(...) {
  try {
     ...
      updateSessionsPerUser(userName);
    } catch (HiveSQLException e) {
      throw new LensException("Error restoring session " + sessionHandle, e);
    }
 }


- Raju


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39576/#review121233
-----------------------------------------------------------


On Feb. 29, 2016, 11:10 p.m., Raju Bairishetti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39576/
> -----------------------------------------------------------
> 
> (Updated Feb. 29, 2016, 11:10 p.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal.
> 
> 
> Bugs: LENS-833
>     https://issues.apache.org/jira/browse/LENS-833
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Failing the open session operation if user creates more sessions than 
> configured limit.
> 
> Created LensHttpStatus for adding new status codes in the Response class. 
> Both Status from Response class and LensHttpStatus implements StatusType 
> interface.
> Changed teh parameter type to StatusType to make it generic
> 
> 
> Diffs
> -----
> 
>   
> lens-api/src/main/java/org/apache/lens/api/error/ErrorCollectionFactory.java 
> 741630b 
>   lens-api/src/main/java/org/apache/lens/api/error/LensError.java 1cb7409 
>   lens-api/src/main/java/org/apache/lens/api/error/LensHttpStatus.java 
> PRE-CREATION 
>   lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java 
> 238f9e6 
>   lens-api/src/main/resources/lens-errors.conf 09b221f 
>   
> lens-cli/src/test/java/org/apache/lens/cli/TestLensConnectionCliCommands.java 
> 558e97f 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeCommands.java 
> 97ca2c8 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDatabaseCommands.java 
> 32ed7b0 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionCommands.java 
> 45555f4 
>   
> lens-cli/src/test/java/org/apache/lens/cli/TestLensDimensionTableCommands.java
>  bea128b 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommands.java 
> 1454e5f 
>   
> lens-cli/src/test/java/org/apache/lens/cli/TestLensFactCommandsWithMissingWeight.java
>  9fce233 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensLogResourceCommands.java 
> f4b043e 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensNativeTableCommands.java 
> e5f11f2 
>   lens-cli/src/test/java/org/apache/lens/cli/TestLensStorageCommands.java 
> a178296 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
>  1b7d0f9 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/error/LensException.java
>  a1ffeb6 
>   lens-server/src/main/java/org/apache/lens/server/BaseLensService.java 
> 0821fe7 
>   
> lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java
>  dc20f0f 
>   
> lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java 
> ac77418 
>   lens-server/src/main/resources/lensserver-default.xml a711d03 
>   lens-server/src/test/java/org/apache/lens/server/TestServerMode.java 
> caf968a 
>   
> lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java
>  8e22837 
>   
> lens-server/src/test/java/org/apache/lens/server/common/ErrorResponseExpectedData.java
>  4d4f137 
>   
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
>  a541e9b 
>   
> lens-server/src/test/java/org/apache/lens/server/query/QueryAPIErrorResponseTest.java
>  30f7aff 
>   lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java 
> a5ee5cc 
>   
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java
>  bde7b9b 
>   
> lens-server/src/test/java/org/apache/lens/server/ui/TestSessionUIResource.java
>  be87e65 
>   lens-server/src/test/resources/lens-site.xml c3187a8 
>   src/site/apt/admin/config.apt fb15d83 
> 
> Diff: https://reviews.apache.org/r/39576/diff/
> 
> 
> Testing
> -------
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.737s]
> [INFO] Lens .............................................. SUCCESS [3.140s]
> [INFO] Lens API .......................................... SUCCESS [22.188s]
> [INFO] Lens API for server and extensions ................ SUCCESS [16.051s]
> [INFO] Lens Cube ......................................... SUCCESS [9:34.494s]
> [INFO] Lens DB storage ................................... SUCCESS [17.660s]
> [INFO] Lens Query Library ................................ SUCCESS [19.226s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:55.805s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [49.269s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.175s]
> [INFO] Lens Server ....................................... SUCCESS 
> [20:34.425s]
> [INFO] Lens client ....................................... SUCCESS [30.663s]
> [INFO] Lens CLI .......................................... SUCCESS [47.568s]
> [INFO] Lens Examples ..................................... SUCCESS [11.947s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.749s]
> [INFO] Lens Distribution ................................. SUCCESS [8.793s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:10.207s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.813s]
> [INFO] Lens Regression ................................... SUCCESS [13.033s]
> [INFO] Lens UI ........................................... SUCCESS [0.157s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 38:42.684s
> [INFO] Finished at: Tue Mar 01 01:47:10 SGT 2016
> [INFO] Final Memory: 185M/1085M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Raju Bairishetti
> 
>

Reply via email to