----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45028/#review124179 -----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java (line 133) <https://reviews.apache.org/r/45028/#comment186613> Are we supporting HDFS path in this patch? lens-client/src/main/java/org/apache/lens/client/LensConnection.java (line 337) <https://reviews.apache.org/r/45028/#comment186614> are we considering type value in method body? lens-client/src/main/java/org/apache/lens/client/LensConnection.java (line 342) <https://reviews.apache.org/r/45028/#comment186615> Should we validate the file existence and type? lens-client/src/main/java/org/apache/lens/client/LensConnection.java (line 344) <https://reviews.apache.org/r/45028/#comment186618> Empty comments can be removed lens-client/src/main/java/org/apache/lens/client/LensConnection.java (line 346) <https://reviews.apache.org/r/45028/#comment186617> should we make it same as file name ? lens-client/src/main/java/org/apache/lens/client/LensConnection.java (line 358) <https://reviews.apache.org/r/45028/#comment186619> jar size restriction needs to be checked before uploading lens-client/src/main/java/org/apache/lens/client/LensConnection.java (line 363) <https://reviews.apache.org/r/45028/#comment186620> In case of failure, should be log ? lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (line 1718) <https://reviews.apache.org/r/45028/#comment186625> type is not making much sense as the REST url mentions it as jar : databases/jar . Can we change the rest end point to something more general? lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (line 1727) <https://reviews.apache.org/r/45028/#comment186621> we need to chnage the order to APPLICATION_XML,APPLICATION_JSON,TEXT_PLAIN lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (line 1734) <https://reviews.apache.org/r/45028/#comment186623> Needs to be logged via logger Partial review .. - Puneet Gupta On March 18, 2016, 1:59 p.m., Badrinath Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45028/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 1:59 p.m.) > > > Review request for lens. > > > Bugs: LENS-317 > https://issues.apache.org/jira/browse/LENS-317 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java > 05108f0158b655653f0665da80a2d10b24f33233 > lens-client/src/main/java/org/apache/lens/client/LensClient.java > ea0cd7630b155965d38bcb2db4c778339704164f > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > eeb473afa101206f9268d7aaa6a44115c02e95c5 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > c11fd831aef7713e1d093f09ea777a2aa6b61db8 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > a1acd1a7aecb31d2a497811afeb58b900c5f73df > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > e7d545cfb161409e74df93716d74cdebc9863b2a > > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java > 72f5c534b02a1fc51ca1fdd98954b113564878e9 > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > e48eab4e297c56c77109a58d901fbdf295946e6e > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > fb757e4672dc4e725121dae417a9be4a5af3a313 > lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java > b651b79163266e5c9e121dba83efcb4bfd5262a9 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestDatabaseService.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java > 1008faf8ab6a5dbe5ec4a4ec4bc83b70075f33e2 > lens-server/src/test/resources/lens-site.xml > c3187a8de929829f8247f814c9bf002d43c67a46 > > Diff: https://reviews.apache.org/r/45028/diff/ > > > Testing > ------- > > > Thanks, > > Badrinath Kulkarni > >
