----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45028/#review125001 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 838) <https://reviews.apache.org/r/45028/#comment187766> is current db always set ? I am not sure about the default case and how we are handling it lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 865) <https://reviews.apache.org/r/45028/#comment187747> This case needs to be be synchronized lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 867) <https://reviews.apache.org/r/45028/#comment187749> Should we change the message to Jar can't be uploaded as another database jar upload is in progress. Pleas try again later! lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 878) <https://reviews.apache.org/r/45028/#comment187753> Can DB name have _ char ? if yes, this logic can break. lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 879) <https://reviews.apache.org/r/45028/#comment187762> Can we also have more than on digits. Like db1-11.jar? In that case substring logic needs to be changed lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 886) <https://reviews.apache.org/r/45028/#comment187763> We need to syncronize the logic to arrive at name . Multiple threads can arrive at same name otherwsie. I would suggest to syncronize entire addDBJar logic taking db (to which jar is being uploaded) as the monitor. That will simplify the code. lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 896) <https://reviews.apache.org/r/45028/#comment187768> Rename opeartion returns a boolean status. Please handle that case where rename fails. lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 900) <https://reviews.apache.org/r/45028/#comment187771> The message can have more info (may be file path). As of now the exception loggeed has the exeception class name already lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 929) <https://reviews.apache.org/r/45028/#comment187773> This can be the first statement in finally, just to make sure its always executed - Puneet Gupta On March 18, 2016, 1:59 p.m., Badrinath Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45028/ > ----------------------------------------------------------- > > (Updated March 18, 2016, 1:59 p.m.) > > > Review request for lens. > > > Bugs: LENS-317 > https://issues.apache.org/jira/browse/LENS-317 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java > 05108f0158b655653f0665da80a2d10b24f33233 > lens-client/src/main/java/org/apache/lens/client/LensClient.java > ea0cd7630b155965d38bcb2db4c778339704164f > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > eeb473afa101206f9268d7aaa6a44115c02e95c5 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > c11fd831aef7713e1d093f09ea777a2aa6b61db8 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > a1acd1a7aecb31d2a497811afeb58b900c5f73df > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > e7d545cfb161409e74df93716d74cdebc9863b2a > > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java > 72f5c534b02a1fc51ca1fdd98954b113564878e9 > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > e48eab4e297c56c77109a58d901fbdf295946e6e > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > fb757e4672dc4e725121dae417a9be4a5af3a313 > lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java > b651b79163266e5c9e121dba83efcb4bfd5262a9 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestDatabaseService.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java > 1008faf8ab6a5dbe5ec4a4ec4bc83b70075f33e2 > lens-server/src/test/resources/lens-site.xml > c3187a8de929829f8247f814c9bf002d43c67a46 > > Diff: https://reviews.apache.org/r/45028/diff/ > > > Testing > ------- > > > Thanks, > > Badrinath Kulkarni > >
