----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45382/#review126080 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/FIFOQueryComparator.java (lines 30 - 31) <https://reviews.apache.org/r/45382/#comment188984> `new Long` might be redundant. lens-server/src/main/java/org/apache/lens/server/query/QueryContextPriorityComparator.java (line 27) <https://reviews.apache.org/r/45382/#comment188985> it can extend FIFO comparator too. and as a fallback call `super.compare`, like the other class. lens-server/src/main/java/org/apache/lens/server/query/QueryContextPriorityComparator.java (line 28) <https://reviews.apache.org/r/45382/#comment188986> We have `QueryPriorityComparator` now. We can remove this class. lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 139) <https://reviews.apache.org/r/45382/#comment188988> `queuedQueries` is getting initialized in `init`. Let's not initialize here. lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 223) <https://reviews.apache.org/r/45382/#comment188987> make it `Comparator<QueryContext>` lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (lines 368 - 369) <https://reviews.apache.org/r/45382/#comment188989> Instead of FIFO, use `Comparator<QueryContext>` everywhere in this class. - Rajat Khandelwal On March 29, 2016, 7:43 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45382/ > ----------------------------------------------------------- > > (Updated March 29, 2016, 7:43 p.m.) > > > Review request for lens. > > > Bugs: LENS-995 > https://issues.apache.org/jira/browse/LENS-995 > > > Repository: lens > > > Description > ------- > > Query priority comparison changed from cost to priority. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > f8a936a > > lens-server/src/main/java/org/apache/lens/server/query/FIFOQueryComparator.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryContextPriorityComparator.java > b25ad79 > > lens-server/src/main/java/org/apache/lens/server/query/QueryCostComparator.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 581530f > > lens-server/src/main/java/org/apache/lens/server/query/QueryPriorityComparator.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/QueryContextComparatorTest.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/QueryContextPriorityComparatorTest.java > 5ab9144 > > lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java > d4b6bdf > > lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java > 7789a4c > > Diff: https://reviews.apache.org/r/45382/diff/ > > > Testing > ------- > > Updated unit tests. Will update the full test result shortly. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.477s] > [INFO] Lens .............................................. SUCCESS [3.813s] > [INFO] Lens API .......................................... SUCCESS [35.017s] > [INFO] Lens API for server and extensions ................ SUCCESS [24.324s] > [INFO] Lens Cube ......................................... SUCCESS > [12:14.047s] > [INFO] Lens DB storage ................................... SUCCESS [21.366s] > [INFO] Lens Query Library ................................ SUCCESS [18.277s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:05.696s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [45.531s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [22.475s] > [INFO] Lens Server ....................................... SUCCESS > [18:50.302s] > [INFO] Lens client ....................................... SUCCESS [35.381s] > [INFO] Lens CLI .......................................... SUCCESS [2:56.647s] > [INFO] Lens Examples ..................................... SUCCESS [10.500s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.748s] > [INFO] Lens Distribution ................................. SUCCESS [9.533s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:20.887s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.732s] > [INFO] Lens Regression ................................... SUCCESS [13.864s] > [INFO] Lens UI ........................................... SUCCESS [28.555s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 43:02.320s > [INFO] Finished at: Tue Mar 29 12:29:36 UTC 2016 > [INFO] Final Memory: 198M/1713M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
