> On March 30, 2016, 11:06 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > lines 368-369 > > <https://reviews.apache.org/r/45382/diff/4/?file=1318033#file1318033line368> > > > > Instead of FIFO, use `Comparator<QueryContext>` everywhere in this > > class.
Added an interface to handle this. - Sushil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45382/#review126080 ----------------------------------------------------------- On March 30, 2016, 12:51 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45382/ > ----------------------------------------------------------- > > (Updated March 30, 2016, 12:51 p.m.) > > > Review request for lens. > > > Bugs: LENS-995 > https://issues.apache.org/jira/browse/LENS-995 > > > Repository: lens > > > Description > ------- > > Query priority comparison changed from cost to priority. > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > f8a936a > > lens-server/src/main/java/org/apache/lens/server/query/FIFOQueryComparator.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/query/QueryComparator.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryContextPriorityComparator.java > b25ad79 > > lens-server/src/main/java/org/apache/lens/server/query/QueryCostComparator.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 581530f > > lens-server/src/main/java/org/apache/lens/server/query/QueryPriorityComparator.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/QueryContextComparatorTest.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/QueryContextPriorityComparatorTest.java > 5ab9144 > > lens-server/src/test/java/org/apache/lens/server/query/collect/DefaultQueryCollectionTest.java > d4b6bdf > > lens-server/src/test/java/org/apache/lens/server/query/collect/QueryCollectUtil.java > 7789a4c > > Diff: https://reviews.apache.org/r/45382/diff/ > > > Testing > ------- > > Updated unit tests. Will update the full test result shortly. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.874s] > [INFO] Lens .............................................. SUCCESS [3.524s] > [INFO] Lens API .......................................... SUCCESS [31.112s] > [INFO] Lens API for server and extensions ................ SUCCESS [23.374s] > [INFO] Lens Cube ......................................... SUCCESS > [11:55.074s] > [INFO] Lens DB storage ................................... SUCCESS [20.238s] > [INFO] Lens Query Library ................................ SUCCESS [16.724s] > [INFO] Lens Hive Driver .................................. SUCCESS [3:01.391s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [48.909s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.591s] > [INFO] Lens Server ....................................... SUCCESS > [18:32.588s] > [INFO] Lens client ....................................... SUCCESS [44.745s] > [INFO] Lens CLI .......................................... SUCCESS [3:02.082s] > [INFO] Lens Examples ..................................... SUCCESS [11.123s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.770s] > [INFO] Lens Distribution ................................. SUCCESS [9.411s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:29.959s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.250s] > [INFO] Lens Regression ................................... SUCCESS [14.174s] > [INFO] Lens UI ........................................... SUCCESS [30.499s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 42:41.306s > [INFO] Finished at: Wed Mar 30 12:49:56 UTC 2016 > [INFO] Final Memory: 209M/2436M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
