> On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, > > line 230 > > <https://reviews.apache.org/r/41794/diff/7/?file=1350438#file1350438line230> > > > > Is the comment valid any more? If not, Should we remove the following > > line?
Sure. Now that we'll be depending on hive2, we can remove this. > On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote: > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java, > > line 253 > > <https://reviews.apache.org/r/41794/diff/7/?file=1350460#file1350460line253> > > > > Why is the change from driverConf to configuration? This configuration object gets translated to a Map<String, String> and all those values are overlayed in the session one by one. Using HiveConf brings a lot more values and some of the values can not be set at runtime (e.g. `hive.in.test`) > On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, > > line 232 > > <https://reviews.apache.org/r/41794/diff/7/?file=1350473#file1350473line232> > > > > Why is the scope change? TestHiveDriver uses this now. In some places I needed to give mergeDriverConf as false, since if it's true, then sometimes the query's driver conf has a value for `hive.in.test`, which is not allowed to be chaned at runtime. > On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java, > > line 259 > > <https://reviews.apache.org/r/41794/diff/7/?file=1350481#file1350481line259> > > > > Why is session classloader used here? DB class loader should be > > independent of session class loader LensSessionImpl has this: ``` ClassLoader classLoader = getClassLoader(getCurrentDatabase()); Thread.currentThread().setContextClassLoader(classLoader); SessionState.getSessionConf().setClassLoader(classLoader); ``` and `getClassLoader` is asking the db resource service for a classloader. So it's not just a db jars' classloader, it's the session's classloader and also will be used for further operations in the current thread. > On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java, > > line 126 > > <https://reviews.apache.org/r/41794/diff/7/?file=1350480#file1350480line126> > > > > Can you update unit tests for the changes done here? All existing tests are working. Should be enough. This is finding start location of `select` clause, earlier logic was to go back one "distinct" and one "select", now in case of `case` statements, the cursor location is at `when`. I didn't want to go back one `case`, one `distinct` and one `select`. Instead changed logic to go back untill a `select` is found. > On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote: > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java, > > line 545 > > <https://reviews.apache.org/r/41794/diff/7/?file=1350459#file1350459line545> > > > > Hope this change is done in result formatter as well. Is added in FilePersistentFormatter. > On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote: > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java, > > line 100 > > <https://reviews.apache.org/r/41794/diff/7/?file=1350460#file1350460line100> > > > > This would need configuration changes in production as well. right? No. There's a default unit. retryDelaySeconds = (int) conf.getTimeVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_CLIENT_RETRY_DELAY_SECONDS, TimeUnit.SECONDS); > On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java, > > line 943 > > <https://reviews.apache.org/r/41794/diff/7/?file=1350478#file1350478line943> > > > > Is it required any more? Removed - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41794/#review129854 ----------------------------------------------------------- On April 19, 2016, 6:19 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41794/ > ----------------------------------------------------------- > > (Updated April 19, 2016, 6:19 p.m.) > > > Review request for lens. > > > Bugs: LENS-518 > https://issues.apache.org/jira/browse/LENS-518 > > > Repository: lens > > > Description > ------- > > Creating wish for moving to Apache hive dependency instead of forked hive > dependency. We will create follow up issues in lens and hive make them link > here. > > > Diffs > ----- > > lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf > lens-client/pom.xml 4fd01fb2cd9fcb156e31bc1fc3b9832566bc2e9a > lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 42a8eb24a7b6dead7681909a10f9643b810a4a3f > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java > 355a1f0d37d27beec207b4db9b6cce94d0d02268 > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java > 9318603f2ccb979644c49f863e4e841cd5ad3bd8 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > c9b14751013c886be961de585d8113ca543cbe8e > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java > ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > 0d0018879deff0f29903e1ffefd93cd497e1edfe > > lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java > 9fecdbccbf188efd39d770662df3606cbf7d766e > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 18575f68769b1fbd456d82f6a044dda74031e4d1 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java > 590d81b697aa44595865ea56ef24e7b66d006fef > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java > b50ebd28b9fb8843efd02345a836d2e178686212 > lens-cube/src/test/resources/hive-site.xml > 8456f8b6090b953ddbe51604b9e20fbf664cbdc9 > lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f > lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java > ab6f22b34035849275074986466f8015b995cf42 > lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION > lens-driver-es/src/test/resources/logback.xml PRE-CREATION > lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java > 0b46485baf69551eb03ba89cfac980ead0d019eb > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > aa37dcc145bc0782e1e329d8e19f19e5840727fb > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java > 4d52e224a036bea128d2ec0f89d937966d8d1a5c > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java > f53e2b65580fa01bf5049bcdd511f71cf598f4e7 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java > 741294cac27f610b94099c24d59adaa791776487 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java > 4f18c2446e804b4127c1382359d7f38353ec9104 > lens-driver-hive/src/test/resources/hive-site.xml > de5af502ca8347a962aef34756bfb8a22d67f6f8 > lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162 > lens-driver-jdbc/src/test/resources/hive-site.xml > 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e > lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b > lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325 > lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f > > lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java > b3e640f76ce1007fe5370d461aa3f072fa7876bb > lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b > > lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java > c7b9887d58c4372faff2419c219da09a16558b15 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java > 0b08459c1107ce3fc79390d092b4a251a1937c75 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 94b79d00defe79befd1751a6c552ddaf17bdf59d > lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > be31cd88d10dc61840c5a2390408ebed126340ac > lens-server/src/main/java/org/apache/lens/server/LensServices.java > 48b3e002a75b8ea54c9b8672d50bfc8af25f7483 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 0127ef8ae18062955bbd6470e3cda20857e04c24 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 6571dae0ee043a20de303a58ab9553b7fd5fe020 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 42bd4abbec230206db854deae8b1e6362576a351 > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java > 1c0cd3520ed77f12141042f74d69abbf0fd99790 > > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java > 72f5c534b02a1fc51ca1fdd98954b113564878e9 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > 895a819a8469d56eac2e7932ea37a391ee956b17 > > lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java > 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6 > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java > 0f55d9e49312a1668dbff3712032359bb92545fc > > lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java > 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 45f41c2cb473b213021cc9c1db1f4e2f36c5859a > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > df13ba268ebfdf09def8616ac8329819b413eb5f > > lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java > f66f89d933e0c380acd56af921e37da58f97c83d > lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java > 0e640ec66ba45716f4819cfd3d944a6155305078 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java > 5feab715b9a283e0951570a407b464b3bd7007a6 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java > dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484 > lens-server/src/test/resources/hive-site.xml > 441f2741c7c55bace15b6c723caaf8eb76724666 > lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9 > lens-storage-db/src/test/resources/hive-site.xml > 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e > pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31 > src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5 > tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2 > > Diff: https://reviews.apache.org/r/41794/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
