> On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 696 > > <https://reviews.apache.org/r/41794/diff/7/?file=1350455#file1350455line696> > > > > Can we add test for this? > > Rajat Khandelwal wrote: > How should I test this? The function is iterating and just doing > `log.info...` for the lines. No return value. > > Amareshwari Sriramadasu wrote: > We can add logback config to put the status logs in one more file. and > read the file and assert. You can look at TestLogResource as an example.
Couldn't figure out an elegent way, Added in hive driver cleanup which checks whether there are any "Updates from Hive" > On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java, > > line 259 > > <https://reviews.apache.org/r/41794/diff/7/?file=1350481#file1350481line259> > > > > Why is session classloader used here? DB class loader should be > > independent of session class loader > > Rajat Khandelwal wrote: > LensSessionImpl has this: > > ``` > ClassLoader classLoader = getClassLoader(getCurrentDatabase()); > Thread.currentThread().setContextClassLoader(classLoader); > SessionState.getSessionConf().setClassLoader(classLoader); > ``` > > and `getClassLoader` is asking the db resource service for a classloader. > So it's not just a db jars' classloader, it's the session's classloader and > also will be used for further operations in the current thread. > > Amareshwari Sriramadasu wrote: > Current change put up which is chaging db classloader - looks wrong to me. Removed the changes, the changes of `LensSessionImpl` are ratained. > On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, > > line 232 > > <https://reviews.apache.org/r/41794/diff/7/?file=1350473#file1350473line232> > > > > Why is the scope change? > > Rajat Khandelwal wrote: > TestHiveDriver uses this now. In some places I needed to give > mergeDriverConf as false, since if it's true, then sometimes the query's > driver conf has a value for `hive.in.test`, which is not allowed to be chaned > at runtime. QueryContext and related classes now checked out from master. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41794/#review129854 ----------------------------------------------------------- On April 28, 2016, 12:35 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41794/ > ----------------------------------------------------------- > > (Updated April 28, 2016, 12:35 p.m.) > > > Review request for lens. > > > Bugs: LENS-518 > https://issues.apache.org/jira/browse/LENS-518 > > > Repository: lens > > > Description > ------- > > Creating wish for moving to Apache hive dependency instead of forked hive > dependency. We will create follow up issues in lens and hive make them link > here. > > > Diffs > ----- > > lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf > lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919 > lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 42a8eb24a7b6dead7681909a10f9643b810a4a3f > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java > 355a1f0d37d27beec207b4db9b6cce94d0d02268 > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java > 9318603f2ccb979644c49f863e4e841cd5ad3bd8 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > c9b14751013c886be961de585d8113ca543cbe8e > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java > ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java > 0d0018879deff0f29903e1ffefd93cd497e1edfe > > lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java > 9fecdbccbf188efd39d770662df3606cbf7d766e > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 02571eecfbe21e9da2dd118eb402374bbe1e3729 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java > 590d81b697aa44595865ea56ef24e7b66d006fef > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java > b50ebd28b9fb8843efd02345a836d2e178686212 > lens-cube/src/test/resources/hive-site.xml > 8456f8b6090b953ddbe51604b9e20fbf664cbdc9 > lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f > > lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java > 38d91f9cc51b6fa66e8ef5720933bcf6b390668b > lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java > ab6f22b34035849275074986466f8015b995cf42 > lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java > 77300f9258816402e28ee92413d1d934c99bfb94 > > lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java > 0b786391460b80d809d3c1c092e771a15ca057a6 > lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION > lens-driver-es/src/test/resources/logback.xml PRE-CREATION > lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java > 0b46485baf69551eb03ba89cfac980ead0d019eb > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 19a010eabc5646e8e0303f73e4ecef91cff8f19f > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java > 4d52e224a036bea128d2ec0f89d937966d8d1a5c > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java > f53e2b65580fa01bf5049bcdd511f71cf598f4e7 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java > 741294cac27f610b94099c24d59adaa791776487 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > cf5190902f521051a4f8d6f2782944d8990db102 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java > 765bb45394dab45912ff3ff3b1d6681b39b965ed > lens-driver-hive/src/test/resources/hive-site.xml > de5af502ca8347a962aef34756bfb8a22d67f6f8 > lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java > 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java > 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162 > lens-driver-jdbc/src/test/resources/hive-site.xml > 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e > lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b > lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325 > lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f > > lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java > b3e640f76ce1007fe5370d461aa3f072fa7876bb > > lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java > 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b > lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java > da90e0ad3a6cb5227fa72761482ac094bf4ba9ef > > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java > 5295f6826a3c724b3a57e14b529dbf64c4332239 > > lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java > fd5f012059ec5c2b82435fba07d5ca3c23008dae > lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > be31cd88d10dc61840c5a2390408ebed126340ac > lens-server/src/main/java/org/apache/lens/server/LensServices.java > 48b3e002a75b8ea54c9b8672d50bfc8af25f7483 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 0127ef8ae18062955bbd6470e3cda20857e04c24 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 79a628febd1677938705c51475438458d4fafbec > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > f5552dc8c2847c2dda50ed4e98c2ec2774478c45 > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java > 1c0cd3520ed77f12141042f74d69abbf0fd99790 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > 895a819a8469d56eac2e7932ea37a391ee956b17 > > lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java > 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6 > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java > 1fa61efb443f25db5c9c650a613b16f046d40155 > > lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java > 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 45f41c2cb473b213021cc9c1db1f4e2f36c5859a > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > fd6bae3de365cb93710decc9ec9d786406c7b8cc > > lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java > 2ee4eb1a596f4caaf8e37ee696388dbd08763434 > lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java > 0e640ec66ba45716f4819cfd3d944a6155305078 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java > 5feab715b9a283e0951570a407b464b3bd7007a6 > > lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java > dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484 > lens-server/src/test/resources/hive-site.xml > 441f2741c7c55bace15b6c723caaf8eb76724666 > lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9 > lens-storage-db/src/test/resources/hive-site.xml > 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e > pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9 > src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5 > tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2 > > Diff: https://reviews.apache.org/r/41794/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
