----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46485/#review130059 -----------------------------------------------------------
lens-client/src/main/java/org/apache/lens/client/exceptions/LensClientIOException.java (line 22) <https://reviews.apache.org/r/46485/#comment193681> should it be `extends IOException`? lens-client/src/main/java/org/apache/lens/client/resultset/AbstractResultSet.java (line 94) <https://reviews.apache.org/r/46485/#comment193683> Let's make the class implement `Closeable`. Secondly, it seems like `throws` is redundant. lens-client/src/main/java/org/apache/lens/client/resultset/CsvResultSetReader.java (lines 43 - 45) <https://reviews.apache.org/r/46485/#comment193688> Multiple `getNext` calls will return same line unless combined with `hasNext`. This is counter intuitive while designing an iterator. Refer http://stackoverflow.com/a/29061917 lens-client/src/main/java/org/apache/lens/client/resultset/ResultSet.java (line 29) <https://reviews.apache.org/r/46485/#comment193691> I think this can also implement `Iterator<String[]>` which will imply that the syntax like the following is supported: ``` ResultSet rs = ...; for(String[] line: rs) { ... } ``` lens-client/src/main/java/org/apache/lens/client/resultset/ResultSetReader.java (line 24) <https://reviews.apache.org/r/46485/#comment193685> `implements Iterator<String[]>`? lens-client/src/main/java/org/apache/lens/client/resultset/ZippedCsvResultSet.java (line 35) <https://reviews.apache.org/r/46485/#comment193692> Return type here can be `ZippedCsvResultSetReader` so that someone testing `ZippedCsvResultSet` can directly expect that type when calling `createResultSetReader` without having to type-cast. - Rajat Khandelwal On April 21, 2016, 5:12 p.m., Puneet Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46485/ > ----------------------------------------------------------- > > (Updated April 21, 2016, 5:12 p.m.) > > > Review request for lens. > > > Bugs: LENS-1008 > https://issues.apache.org/jira/browse/LENS-1008 > > > Repository: lens > > > Description > ------- > > The result iterator can have the following methods > public interface ResultSet > { public boolean hasNext(); public String[] next(); public String[] > getColumnNames(); } > This can be used by clients to programmatically consume the result with ease. > > > Have supported Zipped CSV abd CSV for now with configurable delimiter, > encoding and isHeaderPresent. > It can be extend to other formats in future > > Users can access this feature via easily via (Another varaiation avialble > with more options) > LensClient.getCsvResultSet(QueryHandle) > LensClient.getZippedCsvResultSet(QueryHandle) > > > Diffs > ----- > > lens-client/pom.xml 4fd01fb > lens-client/src/main/java/org/apache/lens/client/LensClient.java 9626820 > > lens-client/src/main/java/org/apache/lens/client/exceptions/LensClientIOException.java > PRE-CREATION > > lens-client/src/main/java/org/apache/lens/client/resultset/AbstractResultSet.java > PRE-CREATION > > lens-client/src/main/java/org/apache/lens/client/resultset/CsvResultSet.java > PRE-CREATION > > lens-client/src/main/java/org/apache/lens/client/resultset/CsvResultSetReader.java > PRE-CREATION > lens-client/src/main/java/org/apache/lens/client/resultset/ResultSet.java > PRE-CREATION > > lens-client/src/main/java/org/apache/lens/client/resultset/ResultSetReader.java > PRE-CREATION > > lens-client/src/main/java/org/apache/lens/client/resultset/ZippedCsvResultSet.java > PRE-CREATION > > lens-client/src/main/java/org/apache/lens/client/resultset/ZippedCsvResultSetReader.java > PRE-CREATION > > lens-client/src/main/java/org/apache/lens/client/resultset/ZippedResultSetReader.java > PRE-CREATION > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > 7a00f65 > lens-client/src/test/resources/dim2-part/data.data PRE-CREATION > lens-client/src/test/resources/dim_table.xml PRE-CREATION > lens-client/src/test/resources/fact1.xml PRE-CREATION > lens-client/src/test/resources/lens-client-site.xml b356e5e > lens-client/src/test/resources/local-storage.xml PRE-CREATION > lens-client/src/test/resources/sample-cube.xml PRE-CREATION > lens-client/src/test/resources/test-detail.xml PRE-CREATION > lens-client/src/test/resources/test-dimension.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/46485/diff/ > > > Testing > ------- > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Listening for transport dt_socket at address: 8000 > Running org.apache.lens.client.TestLensClient > Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 145.247 sec - > in org.apache.lens.client.TestLensClient > > Results : > > Tests run: 7, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Puneet Gupta > >
