> On April 22, 2016, 5:12 a.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java, lines
> > 214-216
> > <https://reviews.apache.org/r/46485/diff/1/?file=1354886#file1354886line214>
> >
> > Instead of separate getResultset methods can we have single method
> > which calls appropriate result set looking at file extension?
Will add two methods .
1. ResultSet getCsvHttpResultSet(QueryHandle q, Charset encoding, boolean
isHeaderPresent, char delimiter,
boolean isResultZipped)
2. ResultSet getCsvHttpResultSet(QueryHandle q).
The second method will delegate to the first one by guessing values for
encoding, isHeaderPresent and delimiter based on session parameters .
> On April 22, 2016, 5:12 a.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java, line
> > 48
> > <https://reviews.apache.org/r/46485/diff/1/?file=1354886#file1354886line48>
> >
> > Can you remove if group is not required?
commented by mistake. Uncommented.
> On April 22, 2016, 5:12 a.m., Amareshwari Sriramadasu wrote:
> > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java, line
> > 194
> > <https://reviews.apache.org/r/46485/diff/1/?file=1354886#file1354886line194>
> >
> > Can we run with CSVserde you are using opencsv to read result?
Was facing some issue in MR job with CSVserde. Switched to LazySimpleSerDe
which is being used in all other test cases as well. Is this OK?
- Puneet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46485/#review130033
-----------------------------------------------------------
On April 21, 2016, 11:42 a.m., Puneet Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46485/
> -----------------------------------------------------------
>
> (Updated April 21, 2016, 11:42 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1008
> https://issues.apache.org/jira/browse/LENS-1008
>
>
> Repository: lens
>
>
> Description
> -------
>
> The result iterator can have the following methods
> public interface ResultSet
> { public boolean hasNext(); public String[] next(); public String[]
> getColumnNames(); }
> This can be used by clients to programmatically consume the result with ease.
>
>
> Have supported Zipped CSV abd CSV for now with configurable delimiter,
> encoding and isHeaderPresent.
> It can be extend to other formats in future
>
> Users can access this feature via easily via (Another varaiation avialble
> with more options)
> LensClient.getCsvResultSet(QueryHandle)
> LensClient.getZippedCsvResultSet(QueryHandle)
>
>
> Diffs
> -----
>
> lens-client/pom.xml 4fd01fb
> lens-client/src/main/java/org/apache/lens/client/LensClient.java 9626820
>
> lens-client/src/main/java/org/apache/lens/client/exceptions/LensClientIOException.java
> PRE-CREATION
>
> lens-client/src/main/java/org/apache/lens/client/resultset/AbstractResultSet.java
> PRE-CREATION
>
> lens-client/src/main/java/org/apache/lens/client/resultset/CsvResultSet.java
> PRE-CREATION
>
> lens-client/src/main/java/org/apache/lens/client/resultset/CsvResultSetReader.java
> PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/resultset/ResultSet.java
> PRE-CREATION
>
> lens-client/src/main/java/org/apache/lens/client/resultset/ResultSetReader.java
> PRE-CREATION
>
> lens-client/src/main/java/org/apache/lens/client/resultset/ZippedCsvResultSet.java
> PRE-CREATION
>
> lens-client/src/main/java/org/apache/lens/client/resultset/ZippedCsvResultSetReader.java
> PRE-CREATION
>
> lens-client/src/main/java/org/apache/lens/client/resultset/ZippedResultSetReader.java
> PRE-CREATION
> lens-client/src/test/java/org/apache/lens/client/TestLensClient.java
> 7a00f65
> lens-client/src/test/resources/dim2-part/data.data PRE-CREATION
> lens-client/src/test/resources/dim_table.xml PRE-CREATION
> lens-client/src/test/resources/fact1.xml PRE-CREATION
> lens-client/src/test/resources/lens-client-site.xml b356e5e
> lens-client/src/test/resources/local-storage.xml PRE-CREATION
> lens-client/src/test/resources/sample-cube.xml PRE-CREATION
> lens-client/src/test/resources/test-detail.xml PRE-CREATION
> lens-client/src/test/resources/test-dimension.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46485/diff/
>
>
> Testing
> -------
>
> -------------------------------------------------------
> T E S T S
> -------------------------------------------------------
> Listening for transport dt_socket at address: 8000
> Running org.apache.lens.client.TestLensClient
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 145.247 sec -
> in org.apache.lens.client.TestLensClient
>
> Results :
>
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Puneet Gupta
>
>
