> On May 10, 2016, 10:37 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/resources/lenssession-default.xml, line 239 > > <https://reviews.apache.org/r/47159/diff/1/?file=1377370#file1377370line239> > > > > Should we set the value to false from lens-client-default.xml sothat > > sync queries are not cancelled ?
Yeah, this is a must for CLI prespective. But from non-cli presective it should be true. Since we do not have a different properties file specific to cli now, will make this property false as of now. - Puneet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47159/#review132406 ----------------------------------------------------------- On May 10, 2016, 6:37 a.m., Puneet Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47159/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 6:37 a.m.) > > > Review request for lens. > > > Bugs: lens-1032 > https://issues.apache.org/jira/browse/lens-1032 > > > Repository: lens > > > Description > ------- > > Right now, on execute with timeout api, if the query times out, then query > will be still running for people to pull reports. > > We should provide option to kill the query upon timeout for users who are not > interested in result beyond timeout. > > Chnages > ------ > Added property lens.query.cancel.on.timeout (default = true ) > Added queryCancellationPool to Query Service to cancel queries asynchronously > Updated Timeout logic in QueryExecutionServiceImpl#executeTimeoutInternal > HiveDriver : updated check interval for completion listener . Minumum > interval is 5 secs now. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/QueryStatus.java > 67d1e79e5d6c578e13c437c12b4d12428214301a > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 19a010eabc5646e8e0303f73e4ecef91cff8f19f > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 23537cbaa64c4daa8d4fdc4a9602d2e3080196f4 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > f5552dc8c2847c2dda50ed4e98c2ec2774478c45 > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > a0435509a4d4f8136bb0fdc8947cc8e3ffdd38fb > lens-server/src/main/resources/lenssession-default.xml > ce296ccadadbdb378e60f788cbe5ba78086a2768 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > fd6bae3de365cb93710decc9ec9d786406c7b8cc > src/site/apt/admin/session-config.apt > 206d6a4ca54cb22d4d1261215bd3f77675911a65 > > Diff: https://reviews.apache.org/r/47159/diff/ > > > Testing > ------- > > org.apache.lens.server.query.TestQueryService#testAutoCancelOnTimeOut : Pass > > > Thanks, > > Puneet Gupta > >
